egressgw: move endpoint.Networking.Addressing check

inside getEndpointMetadata as that's where the rest of the checks for
the received CiliumEndpoint event live

Signed-off-by: Gilberto Bertin <jibi@cilium.io>

pkg/egressgateway/endpoint.go

@@ -38,6 +38,10 @@ func getEndpointMetadata(endpoint *k8sTypes.CiliumEndpoint, identityLabels label
 		return nil, fmt.Errorf("endpoint has no networking metadata")
 	}
 
+	if len(endpoint.Networking.Addressing) == 0 {
+		return nil, fmt.Errorf("failed to get valid endpoint IPs")
+	}
+
 	for _, pair := range endpoint.Networking.Addressing {
 		if pair.IPV4 != "" {
 			ipv4s = append(ipv4s, net.ParseIP(pair.IPV4).To4())

pkg/egressgateway/manager.go

@@ -345,13 +345,6 @@ func (manager *Manager) addEndpoint(id types.NamespacedName) {
 	// encounter a failure it cannot be retried
 	delete(manager.pendingEndpointEvents, id)
 
-	if len(endpoint.Networking.Addressing) == 0 {
-		logger.WithError(err).
-			Error("Failed to get valid endpoint IPs, skipping update to egress policy.")
-
-		return
-	}
-
 	if epData, err = getEndpointMetadata(endpoint, identityLabels); err != nil {
 		logger.WithError(err).
 			Error("Failed to get valid endpoint metadata, skipping update to egress policy.")