Skip to content

Commit

Permalink
monitor: Fix mismatching frontend service debug trace types
Browse files Browse the repository at this point in the history
It seems they were missed in commit 308d67f ("lb: Use more neutral
terminology"). However, this was harmless as these debug types are no
longer used as of commit f3c40a7 ("datapath: Do not log if svc is not
found"). This commit is essentially cosmetic.

Fixes: 308d67f ("lb: Use more neutral terminology")

Signed-off-by: Chris Tarazi <chris@isovalent.com>
  • Loading branch information
christarazi authored and kkourt committed Oct 25, 2021
1 parent 7586bf2 commit a1de732
Showing 1 changed file with 12 additions and 12 deletions.
24 changes: 12 additions & 12 deletions pkg/monitor/datapath_debug.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,16 +56,16 @@ const (
DbgToHost
DbgToStack
DbgPktHash
DbgLb6LookupMaster
DbgLb6LookupMasterFail
DbgLb6LookupFrontend
DbgLb6LookupFrontendFail
DbgLb6LookupBackendSlot
DbgLb6LookupBackendSlotSuccess
DbgLb6LookupBackendSlotV2Fail
DbgLb6LookupBackendFail
DbgLb6ReverseNatLookup
DbgLb6ReverseNat
DbgLb4LookupMaster
DbgLb4LookupMasterFail
DbgLb4LookupFrontend
DbgLb4LookupFrontendFail
DbgLb4LookupBackendSlot
DbgLb4LookupBackendSlotSuccess
DbgLb4LookupBackendSlotV2Fail
Expand Down Expand Up @@ -294,10 +294,10 @@ func (n *DebugMsg) Message() string {
return fmt.Sprintf("Packet hash=%d (%#x), selected_service=%d", n.Arg1, n.Arg1, n.Arg2)
case DbgRRBackendSlotSel:
return fmt.Sprintf("RR backend slot selection hash=%d (%#x), selected_service=%d", n.Arg1, n.Arg1, n.Arg2)
case DbgLb6LookupMaster:
return fmt.Sprintf("Master service lookup, addr.p4=%x key.dport=%d", n.Arg1, byteorder.NetworkToHost16(uint16(n.Arg2)))
case DbgLb6LookupMasterFail:
return fmt.Sprintf("Master service lookup failed, addr.p2=%x addr.p3=%x", n.Arg1, n.Arg2)
case DbgLb6LookupFrontend:
return fmt.Sprintf("Frontend service lookup, addr.p4=%x key.dport=%d", n.Arg1, byteorder.NetworkToHost16(uint16(n.Arg2)))
case DbgLb6LookupFrontendFail:
return fmt.Sprintf("Frontend service lookup failed, addr.p2=%x addr.p3=%x", n.Arg1, n.Arg2)
case DbgLb6LookupBackendSlot, DbgLb4LookupBackendSlot:
return fmt.Sprintf("Service backend slot lookup: slot=%d, dport=%d", n.Arg1, byteorder.NetworkToHost16(uint16(n.Arg2)))
case DbgLb6LookupBackendSlotV2Fail, DbgLb4LookupBackendSlotV2Fail:
Expand All @@ -310,10 +310,10 @@ func (n *DebugMsg) Message() string {
return fmt.Sprintf("Reverse NAT lookup, index=%d", byteorder.NetworkToHost16(uint16(n.Arg1)))
case DbgLb6ReverseNat:
return fmt.Sprintf("Performing reverse NAT, address.p4=%x port=%d", n.Arg1, byteorder.NetworkToHost16(uint16(n.Arg2)))
case DbgLb4LookupMaster:
return fmt.Sprintf("Master service lookup, addr=%s key.dport=%d", ip4Str(n.Arg1), byteorder.NetworkToHost16(uint16(n.Arg2)))
case DbgLb4LookupMasterFail:
return "Master service lookup failed"
case DbgLb4LookupFrontend:
return fmt.Sprintf("Frontend service lookup, addr=%s key.dport=%d", ip4Str(n.Arg1), byteorder.NetworkToHost16(uint16(n.Arg2)))
case DbgLb4LookupFrontendFail:
return "Frontend service lookup failed"
case DbgLb4LookupBackendSlotSuccess:
return fmt.Sprintf("Service backend slot lookup result: target=%s port=%d", ip4Str(n.Arg1), byteorder.NetworkToHost16(uint16(n.Arg2)))
case DbgLb4ReverseNat:
Expand Down

0 comments on commit a1de732

Please sign in to comment.