Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Data updates are passed in as pointers, deep copies must be made for data passed in and for data passed out. Fixes: ``` WARNING: DATA RACE Write at 0x00c000276970 by goroutine 31: github.com/cilium/cilium/pkg/aws/ec2/mock.(*API).AssignPrivateIpAddresses() /home/vagrant/go/src/github.com/cilium/cilium/pkg/aws/ec2/mock/mock.go:296 +0x4f7 github.com/cilium/cilium/pkg/aws/eni.(*Node).AllocateIPs() /home/vagrant/go/src/github.com/cilium/cilium/pkg/aws/eni/node.go:253 +0x102 github.com/cilium/cilium/pkg/ipam.(*Node).maintainIPPool() /home/vagrant/go/src/github.com/cilium/cilium/pkg/ipam/node.go:502 +0xa0d github.com/cilium/cilium/pkg/ipam.(*Node).MaintainIPPool() /home/vagrant/go/src/github.com/cilium/cilium/pkg/ipam/node.go:532 +0x90 github.com/cilium/cilium/pkg/ipam.(*NodeManager).Update.func1() /home/vagrant/go/src/github.com/cilium/cilium/pkg/ipam/node_manager.go:249 +0x8b github.com/cilium/cilium/pkg/trigger.(*Trigger).waiter() /home/vagrant/go/src/github.com/cilium/cilium/pkg/trigger/trigger.go:206 +0x4b9 ``` ``` WARNING: DATA RACE Read at 0x0000048bffa8 by goroutine 25: github.com/cilium/cilium/pkg/aws/ec2/mock.(*API).CreateNetworkInterface() /home/vagrant/go/src/github.com/cilium/cilium/pkg/aws/ec2/mock/mock.go:199 +0x5fd github.com/cilium/cilium/pkg/aws/eni.(*Node).CreateInterface() /home/vagrant/go/src/github.com/cilium/cilium/pkg/aws/eni/node.go:387 +0x927 github.com/cilium/cilium/pkg/ipam.(*Node).createInterface() /home/vagrant/go/src/github.com/cilium/cilium/pkg/ipam/node.go:330 +0x2d4 github.com/cilium/cilium/pkg/ipam.(*Node).maintainIPPool() /home/vagrant/go/src/github.com/cilium/cilium/pkg/ipam/node.go:516 +0x85d github.com/cilium/cilium/pkg/ipam.(*Node).MaintainIPPool() /home/vagrant/go/src/github.com/cilium/cilium/pkg/ipam/node.go:532 +0x90 github.com/cilium/cilium/pkg/ipam.(*NodeManager).Update.func1() /home/vagrant/go/src/github.com/cilium/cilium/pkg/ipam/node_manager.go:249 +0x8b github.com/cilium/cilium/pkg/trigger.(*Trigger).waiter() /home/vagrant/go/src/github.com/cilium/cilium/pkg/trigger/trigger.go:206 +0x4b9 ``` ``` WARNING: DATA RACE Read at 0x00c0006aa9f0 by goroutine 30: github.com/cilium/cilium/pkg/aws/eni/types.(*ENI).DeepCopyInto() /home/vagrant/go/src/github.com/cilium/cilium/pkg/aws/eni/types/zz_generated.deepcopy.go:60 +0x65 github.com/cilium/cilium/pkg/aws/eni/types.(*ENI).DeepCopy() /home/vagrant/go/src/github.com/cilium/cilium/pkg/aws/eni/types/zz_generated.deepcopy.go:82 +0x476 github.com/cilium/cilium/pkg/aws/ec2/mock.(*API).GetInstances() /home/vagrant/go/src/github.com/cilium/cilium/pkg/aws/ec2/mock/mock.go:382 +0x1b8 github.com/cilium/cilium/pkg/aws/eni.(*InstancesManager).Resync() /home/vagrant/go/src/github.com/cilium/cilium/pkg/aws/eni/instances.go:171 +0x851 github.com/cilium/cilium/pkg/aws/eni.(*ENISuite).TestNodeManagerManyNodes() /home/vagrant/go/src/github.com/cilium/cilium/pkg/aws/eni/node_manager_test.go:570 +0xaf4 runtime.call32() /usr/local/go/src/runtime/asm_amd64.s:539 +0x3a reflect.Value.Call() /usr/local/go/src/reflect/value.go:321 +0xd3 gopkg.in/check%2ev1.(*suiteRunner).forkTest.func1() /home/vagrant/go/src/github.com/cilium/cilium/vendor/gopkg.in/check.v1/check.go:781 +0xa0a gopkg.in/check%2ev1.(*suiteRunner).forkCall.func1() /home/vagrant/go/src/github.com/cilium/cilium/vendor/gopkg.in/check.v1/check.go:675 +0xd9 ``` Signed-off-by: Thomas Graf <thomas@cilium.io>
- Loading branch information