Skip to content

Commit

Permalink
docs: Parameterize READTHEDOCS_VERSION
Browse files Browse the repository at this point in the history
This way you can specify it on the commandline to generate docs in the
way that RTD would by passing the environment variable, eg:

  $ READTHEDOCS_VERSION="v1.8.0-rc2" make render-docs

Signed-off-by: Joe Stringer <joe@cilium.io>
  • Loading branch information
joestringer authored and borkmann committed Jun 3, 2020
1 parent f00dc2a commit d4a968e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions Documentation/Dockerfile
Expand Up @@ -18,6 +18,7 @@ ADD ./requirements.txt /tmp/requirements.txt
RUN pip install -r /tmp/requirements.txt

ENV HOME=/tmp
ENV READTHEDOCS_VERSION=$READTHEDOCS_VERSION

## Workaround odd behaviour of sphinx versionwarning extension. It wants to
## write runtime data inside a system directory.
Expand Down
1 change: 1 addition & 0 deletions Documentation/Makefile
Expand Up @@ -15,6 +15,7 @@ builder-image: Dockerfile requirements.txt
$(QUIET)tar c requirements.txt Dockerfile \
| $(CONTAINER_ENGINE) build --tag cilium/docs-builder -

READTHEDOCS_VERSION:=$(READTHEDOCS_VERSION)
DOCKER_RUN := $(CONTAINER_ENGINE) container run --rm \
--workdir /src/Documentation \
--volume $(CURDIR)/..:/src \
Expand Down

0 comments on commit d4a968e

Please sign in to comment.