Skip to content

Commit

Permalink
loader: don't disable rp-filter for IPsec
Browse files Browse the repository at this point in the history
This was added all the way back with 79b4eba ("cilium: encrypt-node
needs rp_filter zerod otherwise packets are lost"), which matches the
error message in that it's about encryption for node IPs.

But as IPsec now only supports pod-to-pod traffic, we can likely remove
this part.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
  • Loading branch information
julianwiedmann authored and pchaigno committed May 16, 2024
1 parent 4aa6a7f commit e1cf5a1
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions pkg/datapath/loader/base.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import (

"github.com/cilium/cilium/pkg/bpf"
"github.com/cilium/cilium/pkg/datapath/alignchecker"
"github.com/cilium/cilium/pkg/datapath/connector"
"github.com/cilium/cilium/pkg/datapath/linux/ethtool"
"github.com/cilium/cilium/pkg/datapath/linux/linux_defaults"
"github.com/cilium/cilium/pkg/datapath/linux/route"
Expand Down Expand Up @@ -203,10 +202,6 @@ func (l *loader) reinitializeIPSec(ctx context.Context) error {
progs := []progDefinition{{progName: symbolFromNetwork, direction: dirIngress}}
var errs error
for _, iface := range interfaces {
if err := connector.DisableRpFilter(l.sysctl, iface); err != nil {
log.WithError(err).WithField(logfields.Interface, iface).Warn("Rpfilter could not be disabled, node to node encryption may fail")
}

device, err := netlink.LinkByName(iface)
if err != nil {
return fmt.Errorf("retrieving device %s: %w", iface, err)
Expand Down

0 comments on commit e1cf5a1

Please sign in to comment.