Skip to content

Commit

Permalink
bpf: Fix VTEP drop check
Browse files Browse the repository at this point in the history
Commit a94fa56 ("Fix CIDR to World Entity Conversion Bug") seems to
have inadvertently swapped a check for "is not world" to a check for "is
world" in order to drop. This has likely broken the VTEP feature. Fix
it.

Fixes: a94fa56 ("Fix CIDR to World Entity Conversion Bug")
Signed-off-by: Joe Stringer <joe@cilium.io>
  • Loading branch information
joestringer committed Feb 28, 2024
1 parent badd092 commit ef03b0a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion bpf/bpf_overlay.c
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ static __always_inline int handle_ipv4(struct __ctx_buff *ctx,
if (!vtep)
goto skip_vtep;
if (vtep->tunnel_endpoint) {
if (identity_is_world_ipv4(*identity))
if (!identity_is_world_ipv4(*identity))
return DROP_INVALID_VNI;
}
}
Expand Down

0 comments on commit ef03b0a

Please sign in to comment.