Skip to content

Commit

Permalink
daemon, option: remove deprecated flannel-manage-existing-containers …
Browse files Browse the repository at this point in the history
…flag

The flag no longer has any effect and is scheduled for removal in
Cilium 1.8.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
  • Loading branch information
tklauser authored and joestringer committed Jun 10, 2020
1 parent 941e328 commit f6d62b5
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 15 deletions.
4 changes: 2 additions & 2 deletions Documentation/install/upgrade.rst
Original file line number Diff line number Diff line change
Expand Up @@ -575,8 +575,8 @@ Removed options

* ``enable-legacy-services``: This option was deprecated in Cilium 1.6 and is
now removed.
* The options ``container-runtime`` and ``container-runtime-endpoint`` were
deprecated in Cilium 1.7 and are now removed.
* The options ``container-runtime``, ``container-runtime-endpoint`` and
``flannel-manage-existing-containers`` were deprecated in Cilium 1.7 and are now removed.
* The ``conntrack-garbage-collector-interval`` option deprecated in Cilium 1.6
is now removed. Please use ``conntrack-gc-interval`` instead.

Expand Down
6 changes: 0 additions & 6 deletions daemon/cmd/daemon_main.go
Original file line number Diff line number Diff line change
Expand Up @@ -633,12 +633,6 @@ func init() {
"flag, it cleans up all BPF programs installed when Cilium agent is terminated.", option.FlannelMasterDevice))
option.BindEnv(option.FlannelUninstallOnExit)

flags.Bool(option.FlannelManageExistingContainers, false,
fmt.Sprintf("Installs a BPF program to allow for policy enforcement in already running containers managed by Flannel."+
" Require Cilium to be running in the hostPID."))
option.BindEnv(option.FlannelManageExistingContainers)
flags.MarkDeprecated(option.FlannelManageExistingContainers, "This option is no longer supported and will be removed in v1.8")

flags.Bool(option.PProf, false, "Enable serving the pprof debugging API")
option.BindEnv(option.PProf)

Expand Down
7 changes: 0 additions & 7 deletions pkg/option/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -325,13 +325,6 @@ const (
// it cleans up all BPF programs installed when Cilium agent is terminated.
FlannelUninstallOnExit = "flannel-uninstall-on-exit"

// FlannelManageExistingContainers sets if Cilium should install the BPF
// programs on already running interfaces created by flannel. Require
// Cilium to be running in the hostPID.
// Deprecated: This option is no longer available since cilium-daemon does
// not have any direct interaction with container runtimes.
FlannelManageExistingContainers = "flannel-manage-existing-containers"

// PProf enables serving the pprof debugging API
PProf = "pprof"

Expand Down

0 comments on commit f6d62b5

Please sign in to comment.