Skip to content

Commit

Permalink
daemon: Disable kube-proxy replacement sub-features in flags
Browse files Browse the repository at this point in the history
This commit:
- Disables option.Config.EnableExternalIP if NodePort is disabled
- Disables option.EnableHostServices{TCP,UDP} if host-lb is disabled

Otherwise, "cilium status" when --kube-proxy-replacement=partial will
misleadingly report that ExternalIP and HostServices{TCP,UDP} are
enabled even if NodePort and host-lb is disabled.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
  • Loading branch information
brb committed Feb 5, 2020
1 parent 989718f commit fea00f7
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions daemon/daemon_main.go
Original file line number Diff line number Diff line change
Expand Up @@ -1547,5 +1547,12 @@ func initKubeProxyReplacementOptions() {
if !option.Config.EnableHostServicesTCP && !option.Config.EnableHostServicesUDP {
option.Config.EnableHostReachableServices = false
}
} else {
option.Config.EnableHostServicesTCP = false
option.Config.EnableHostServicesUDP = false
}

if !option.Config.EnableNodePort {
option.Config.EnableExternalIPs = false
}
}

0 comments on commit fea00f7

Please sign in to comment.