Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helm NOTES file #10070

Closed
joestringer opened this issue Feb 5, 2020 · 1 comment · Fixed by #10641 or #10902
Closed

Add helm NOTES file #10070

joestringer opened this issue Feb 5, 2020 · 1 comment · Fixed by #10641 or #10902
Labels
good-first-issue Good starting point for new developers, which requires minimal understanding of Cilium.

Comments

@joestringer
Copy link
Member

Helm supports adding a custom piece of text after install, to give users some first pointers and advice what to do next. We should add this with the release, name, maybe a pointer to Slack.

https://helm.sh/docs/chart_template_guide/notes_files/
@soumynathan soumynathan mentioned this issue Mar 19, 2020
Merged
soumynathan added a commit to soumynathan/cilium that referenced this issue Mar 27, 2020
@soumynathan
Add helm NOTES file
5f80e5f 
This patch adds helm NOTES.txt file to the respective template folders.

Fixes: cilium#10070
Signed-off-by: Swaminathan Vasudevan <svasudevan@suse.com>
aanm pushed a commit that referenced this issue Apr 1, 2020
@soumynathan @aanm
Add helm NOTES file
94dcaa7 
This patch adds helm NOTES.txt file to the respective template folders.

Fixes: #10070
Signed-off-by: Swaminathan Vasudevan <svasudevan@suse.com>
joestringer pushed a commit that referenced this issue Apr 2, 2020
@soumynathan @joestringer
Add helm NOTES file
f88a012 
[ upstream commit 94dcaa7 ]

This patch adds helm NOTES.txt file to the respective template folders.

Fixes: #10070
Signed-off-by: Swaminathan Vasudevan <svasudevan@suse.com>
Signed-off-by: Joe Stringer <joe@cilium.io>
@pchaigno pchaigno added the good-first-issue Good starting point for new developers, which requires minimal understanding of Cilium. label Apr 2, 2020
borkmann pushed a commit that referenced this issue Apr 2, 2020
@soumynathan @borkmann
Add helm NOTES file
6c0503c 
[ upstream commit 94dcaa7 ]

This patch adds helm NOTES.txt file to the respective template folders.

Fixes: #10070
Signed-off-by: Swaminathan Vasudevan <svasudevan@suse.com>
Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer
Copy link
Member Author

Latest versions when running helm install do not show the notes, reopening.

@joestringer joestringer reopened this Apr 8, 2020
@soumynathan soumynathan mentioned this issue Apr 8, 2020
Merged
soumynathan added a commit to soumynathan/cilium that referenced this issue Apr 15, 2020
@soumynathan
Add helm NOTES to the root folder
fc4cad2 
This patch adds helm NOTES file to the root folder.

Fixes: cilium#10070
Signed-off-by: Swaminathan Vasudevan <svasudevan@suse.com>
joestringer pushed a commit that referenced this issue Apr 15, 2020
@soumynathan @joestringer
Add helm NOTES to the root folder
193a9f0 
This patch adds helm NOTES file to the root folder.

Fixes: #10070
Signed-off-by: Swaminathan Vasudevan <svasudevan@suse.com>
jrfastab pushed a commit that referenced this issue Apr 23, 2020
@soumynathan @jrfastab
Add helm NOTES to the root folder
a805c48 
[ upstream commit 193a9f0 ]

This patch adds helm NOTES file to the root folder.

Fixes: #10070
Signed-off-by: Swaminathan Vasudevan <svasudevan@suse.com>
Signed-off-by: John Fastabend <john.fastabend@gmail.com>
jrfastab pushed a commit that referenced this issue Apr 28, 2020
@soumynathan @jrfastab
Add helm NOTES to the root folder
74b0b2c 
[ upstream commit 193a9f0 ]

This patch adds helm NOTES file to the root folder.

Fixes: #10070
Signed-off-by: Swaminathan Vasudevan <svasudevan@suse.com>
Signed-off-by: John Fastabend <john.fastabend@gmail.com>
joestringer pushed a commit that referenced this issue Apr 29, 2020
@soumynathan @joestringer
Add helm NOTES to the root folder
3fd2d89 
[ upstream commit 193a9f0 ]

This patch adds helm NOTES file to the root folder.

Fixes: #10070
Signed-off-by: Swaminathan Vasudevan <svasudevan@suse.com>
Signed-off-by: John Fastabend <john.fastabend@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue Good starting point for new developers, which requires minimal understanding of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add helm NOTES file soumynathan/cilium
Add helm NOTES to the root folder soumynathan/cilium
2 participants
@joestringer @pchaigno