Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIGSEGV in pkg/ipam/node.go #10582

Closed
tgraf opened this issue Mar 15, 2020 · 0 comments
Closed

SIGSEGV in pkg/ipam/node.go #10582

tgraf opened this issue Mar 15, 2020 · 0 comments
Assignees
@tgraf
Labels
kind/bug This is a bug in the Cilium logic.

Comments

@tgraf
Copy link
Member

tgraf commented Mar 15, 2020 

[signal SIGSEGV: segmentation violation code=0x1 addr=0x250 pc=0x1768d37]
goroutine 21 [running]:
github.com/cilium/cilium/pkg/ipam.(*Node).recalculateLocked(0xc000036780)
	/home/travis/gopath/src/github.com/cilium/cilium/pkg/ipam/node.go:264 +0xc7
github.com/cilium/cilium/pkg/ipam.(*NodeManager).resyncNode(0xc00015c850, 0x1eb1120, 0xc0000561e0, 0xc000036780, 0xc00047a7c0, 0xbf93aabab7244bc5, 0x1cde30d, 0x2d7f160)
	/home/travis/gopath/src/github.com/cilium/cilium/pkg/ipam/node_manager.go:356 +0xa7
github.com/cilium/cilium/pkg/ipam.(*NodeManager).Resync.func1(0xc00015c850, 0x1eb1120, 0xc0000561e0, 0xbf93aabab7244bc5, 0x1cde30d, 0x2d7f160, 0xc0002900f0, 0xc000036780, 0xc00047a7c0)
	/home/travis/gopath/src/github.com/cilium/cilium/pkg/ipam/node_manager.go:402 +0x81
created by github.com/cilium/cilium/pkg/ipam.(*NodeManager).Resync
	/home/travis/gopath/src/github.com/cilium/cilium/pkg/ipam/node_manager.go:401 +0x1cc
FAIL	github.com/cilium/cilium/pkg/azure/ipam	0.044s
@tgraf tgraf added the kind/bug This is a bug in the Cilium logic. label Mar 15, 2020
@tgraf tgraf self-assigned this Mar 15, 2020
@tgraf tgraf mentioned this issue Mar 16, 2020
Merged
tgraf added a commit that referenced this issue Mar 16, 2020
@tgraf
ipam: Fix SIGSEGV when accessing n.resource
353d883 
It is possible for the IP deficit resolution to be triggered before the
initial CiliumNode resource is asigned to the node. n.resource can be
nil in this scenario.

Fixes: #10582

Signed-off-by: Thomas Graf <thomas@cilium.io>
tgraf added a commit that referenced this issue Mar 16, 2020
@tgraf
ipam: Fix SIGSEGV when accessing n.resource
f9ca6a8 
It is possible for the IP deficit resolution to be triggered before the
initial CiliumNode resource is asigned to the node. n.resource can be
nil in this scenario.

Fixes: #10582

Signed-off-by: Thomas Graf <thomas@cilium.io>
@aanm aanm closed this as completed in f3152ae Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tgraf tgraf

Labels
kind/bug This is a bug in the Cilium logic.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tgraf