Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate avoiding redeploying DNS for every DatapathConfiguration test #10980

Closed
joestringer opened this issue Apr 15, 2020 · 0 comments · Fixed by #11207
Closed

Investigate avoiding redeploying DNS for every DatapathConfiguration test #10980

joestringer opened this issue Apr 15, 2020 · 0 comments · Fixed by #11207
Labels
area/CI-improvement Topic or proposal to improve the Continuous Integration workflow help-wanted Please volunteer for this by adding yourself as an assignee!

Comments

@joestringer
Copy link
Member

joestringer commented Apr 15, 2020 •
edited

DatapathConfiguration tests deploy Cilium and DNS for each test, which introduces delay waiting for the cluster to become ready again, including DNS pod redeployment:

cilium/test/k8sT/DatapathConfiguration.go

Line 130 in 7abdfa3

DeployCiliumOptionsAndDNS(kubectl, ciliumFilename, options)

This occurs about ~20 times in the current tests, we should investigate whether it's reasonable to skip redeploying DNS in this scenario; it could shave a few minutes off CI runs.

In my GKE runs, this seems to take as much as 30s per DNS deployment.
@joestringer joestringer added area/CI-improvement Topic or proposal to improve the Continuous Integration workflow help-wanted Please volunteer for this by adding yourself as an assignee! labels Apr 15, 2020
joestringer added a commit to joestringer/cilium that referenced this issue Apr 16, 2020
@joestringer
test: Add RedeployCilium() helper
f587081 
This helper will redeploy Cilium without redeploying DNS, to save some
time in situations where we know that DNS is already deployed and under
Cilium control.

Related: cilium#10980

Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer added a commit that referenced this issue Apr 16, 2020
@joestringer
test: Add RedeployCilium() helper
aa0eaad 
This helper will redeploy Cilium without redeploying DNS, to save some
time in situations where we know that DNS is already deployed and under
Cilium control.

Related: #10980

Signed-off-by: Joe Stringer <joe@cilium.io>
jrajahalme pushed a commit that referenced this issue Apr 17, 2020
@joestringer @jrajahalme
test: Add RedeployCilium() helper
44461db 
[ upstream commit aa0eaad ]

This helper will redeploy Cilium without redeploying DNS, to save some
time in situations where we know that DNS is already deployed and under
Cilium control.

Related: #10980

Signed-off-by: Joe Stringer <joe@cilium.io>
Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
joestringer added a commit that referenced this issue Apr 20, 2020
@joestringer
test: Add RedeployCilium() helper
54d0658 
[ upstream commit aa0eaad ]

This helper will redeploy Cilium without redeploying DNS, to save some
time in situations where we know that DNS is already deployed and under
Cilium control.

Related: #10980

Signed-off-by: Joe Stringer <joe@cilium.io>
Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
joestringer added a commit that referenced this issue Apr 21, 2020
@joestringer
test: Add RedeployCilium() helper
27ed56f 
[ upstream commit aa0eaad ]

This helper will redeploy Cilium without redeploying DNS, to save some
time in situations where we know that DNS is already deployed and under
Cilium control.

Related: #10980

Signed-off-by: Joe Stringer <joe@cilium.io>
Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
@joestringer joestringer mentioned this issue May 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/CI-improvement Topic or proposal to improve the Continuous Integration workflow help-wanted Please volunteer for this by adding yourself as an assignee!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Only restart KubeDNS if required cilium/cilium
1 participant
@joestringer