Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected {{end}} in helm chart #11398

Closed
sayboras opened this issue May 7, 2020 · 3 comments · Fixed by #11400
Closed

Unexpected {{end}} in helm chart #11398

sayboras opened this issue May 7, 2020 · 3 comments · Fixed by #11400
Labels
kind/community-report This was reported by a user in the Cilium community, eg via Slack.

Comments

@sayboras
Copy link
Member

sayboras commented May 7, 2020

Just found out about this, while playing around with current helm in EKS.

$ helm lint
==> Linting .
[INFO] Chart.yaml: icon is recommended
[ERROR] templates/: parse error at (cilium/charts/hubble-ui/templates/serviceaccount.yaml:10): unexpected {{end}}

Error: 1 chart(s) linted, 1 chart(s) failed
@sayboras
Copy link
Member Author

sayboras commented May 7, 2020

Feel like we can run basic linting and helm test as part of PR as well.

@sayboras sayboras mentioned this issue May 7, 2020
Merged
sayboras added a commit to sayboras/cilium that referenced this issue May 7, 2020
@sayboras
fix(helm): To fix un-expected {{end}} in helm template
7abd7d5 
The block {{end}} at the end was not expected. This should be
removed. Moreover, I add basic helm lint and test to avoid
such kind of issue in future. This is running as non mandatory
step by github action

Closes cilium#11398

Signed-off-by: Tam Mach <sayboras@yahoo.com>
@tklauser tklauser added the kind/community-report This was reported by a user in the Cilium community, eg via Slack. label May 7, 2020
@tklauser
Copy link
Member

tklauser commented May 7, 2020

Regarding linting: on a somewhat similar topic there's also #10425 reported with a draft PR at #10431. Maybe these linting/consistency checks could be combined in a single CI action?

/cc @fristonio who has been working on said PR.

@sayboras
Copy link
Member Author

sayboras commented May 8, 2020

@tklauser thanks for your info. I feel like it's exactly the same idea, but I took github action route to simplify some of the scripting effort.

As developer, it's always great to have steps runnable locally as well

@sayboras sayboras mentioned this issue May 8, 2020
Closed
sayboras added a commit to sayboras/cilium that referenced this issue May 8, 2020
@sayboras
fix(helm): To fix un-expected {{end}} in helm template
921791b 
The block {{end}} at the end was not expected. This should be
removed. Moreover, I add basic helm lint and test to avoid
such kind of issue in future. This is running as non mandatory
step by github action

Closes cilium#11398

Signed-off-by: Tam Mach <sayboras@yahoo.com>
tgraf pushed a commit that referenced this issue May 11, 2020
@sayboras @tgraf
fix(helm): To fix un-expected {{end}} in helm template
51934c8 
The block {{end}} at the end was not expected. This should be
removed. Moreover, I add basic helm lint and test to avoid
such kind of issue in future. This is running as non mandatory
step by github action

Closes #11398

Signed-off-by: Tam Mach <sayboras@yahoo.com>
@sayboras sayboras mentioned this issue May 15, 2020
Closed
@aanm aanm mentioned this issue May 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/community-report This was reported by a user in the Cilium community, eg via Slack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(helm): To fix un-expected {{end}} in helm template sayboras/cilium
2 participants
@tklauser @sayboras