Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: session affinity failing with kube-proxy-replacement=disabled #16163

Closed
aanm opened this issue May 14, 2021 · 5 comments
Closed

CI: session affinity failing with kube-proxy-replacement=disabled #16163

aanm opened this issue May 14, 2021 · 5 comments
Assignees
Labels
kind/bug This is a bug in the Cilium logic. priority/high This is considered vital to an upcoming release.

Comments

@aanm
Copy link
Member

aanm commented May 14, 2021

Kubernetes conformance tests (test/kubernetes-test.sh + jenkinsfiles/kubernetes-upstream.Jenkinsfile) are currently failing when being run with kube-proxy-replacement=disabled:

17:09:03  Summarizing 3 Failures:
17:09:03  
17:09:03  [Fail] [sig-network] Services [It] should be able to switch session affinity for service with type clusterIP [LinuxOnly] [Conformance] 
17:09:03  /home/vagrant/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/network/service.go:206
17:09:03  
17:09:03  [Fail] [sig-network] Services [It] should have session affinity timeout work for service with type clusterIP [LinuxOnly] [Conformance] 
17:09:03  /home/vagrant/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/network/service.go:206
17:09:03  
17:09:03  [Fail] [sig-network] Services [It] should have session affinity work for service with type clusterIP [LinuxOnly] [Conformance] 
17:09:03  /home/vagrant/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/network/service.go:206

Tested with v1.10 branch and v1.9.1 and v1.9.6 tags in 5.12 kernel. Our CI is running k8s e2e tests in 4.19 kernel.

Marking as high priority since we switched our default to kube-proxy-replacement=disabled in #15422

More information about the test failure: https://jenkins.cilium.io/job/Cilium-PR-K8s-Upstream/3089/execution/node/73/log/

The tests will start to pass again once #16162 is merged.

@aanm aanm added kind/bug This is a bug in the Cilium logic. priority/high This is considered vital to an upcoming release. needs-backport/1.10 labels May 14, 2021
@aanm aanm assigned brb and borkmann May 14, 2021
@brb
Copy link
Member

brb commented May 16, 2021

@aanm Could you rerun the test with --enable-session-affinity=true? #13480 intended to make it enabled by default.

@aanm
Copy link
Member Author

aanm commented May 17, 2021

@brb with --debug --pprof --enable-hubble --hubble-listen-address :4244 --enable-k8s-event-handover --k8s-require-ipv4-pod-cidr --enable-bandwidth-manager --kube-proxy-replacement disabled --enable-remote-node-identity --enable-ipv6-ndp --ipv6-mcast-device enp0s8 -t vxlan --k8s-kubeconfig-path /var/lib/cilium/cilium.kubeconfig --identity-allocation-mode=crd --enable-k8s-event-handover=false --enable-session-affinity=true it also fails.

Is enable-session-affinity enabled even if kube-proxy-replacement is disabled?

@brb
Copy link
Member

brb commented May 17, 2021

Is enable-session-affinity enabled even if kube-proxy-replacement is disabled?

No, see the PR linked above.

@borkmann
Copy link
Member

Is enable-session-affinity enabled even if kube-proxy-replacement is disabled?

No, see the PR linked above.

You would have to default to partial with enable-session-affinity instead. Then it will work.

errordeveloper added a commit to cilium/cilium-olm that referenced this issue Jun 25, 2021
@brb
Copy link
Member

brb commented Jul 14, 2022

#16179 should have fixed the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is a bug in the Cilium logic. priority/high This is considered vital to an upcoming release.
Projects
None yet
Development

No branches or pull requests

3 participants