-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Maglev unit test failing on newer kernels with: update failed: invalid argument
#16844
Comments
sugangli
added
area/CI
Continuous Integration testing issue or flake
ci/flake
This is a known failure that occurs in the tree. Please investigate me!
labels
Jul 9, 2021
pchaigno
changed the title
CI: CI skips maglev unit test due to the test VM has an old kernel
CI: Maglev unit test failing on newer kernels with: update failed: invalid argument
Jul 9, 2021
pchaigno
changed the title
CI: Maglev unit test failing on newer kernels with: update failed: invalid argument
CI: Maglev unit test failing on newer kernels with: Jul 9, 2021
update failed: invalid argument
jibi
added a commit
that referenced
this issue
Jul 12, 2021
When a maglev BPF map is initialized, before creating it we check if it already exists, and if its inner map size matches the desired maglev table size ("M" parameter), so that we can delete and recreate it in case of a mismatch. The lbmap.MaglevOuterMapTableSize function is reponsible for reporting to the caller if the map already exists and its inner map size. Currently, if the map exists but its empty, MaglevOuterMapTableSize will incorrectly return false (i.e. "map does not exist"), preventing lbmap.deleteMapIfMNotMatch from deleting it in case of a mismatch with the M parameter. This commit fixes this logic. Fixes: #16844 Fixes: 879f9eb Signed-off-by: Gilberto Bertin <gilberto@isovalent.com>
jibi
added a commit
that referenced
this issue
Jul 13, 2021
When a maglev BPF map is initialized, before creating it we check if it already exists, and if its inner map size matches the desired maglev table size ("M" parameter), so that we can delete and recreate it in case of a mismatch. The lbmap.MaglevOuterMapTableSize function is reponsible for reporting to the caller if the map already exists and its inner map size. Currently, if the map exists but its empty, MaglevOuterMapTableSize will incorrectly return false (i.e. "map does not exist"), preventing lbmap.deleteMapIfMNotMatch from deleting it in case of a mismatch with the M parameter. This commit fixes this logic. Fixes: #16844 Fixes: 879f9eb Signed-off-by: Gilberto Bertin <gilberto@isovalent.com>
aanm
pushed a commit
that referenced
this issue
Jul 19, 2021
When a maglev BPF map is initialized, before creating it we check if it already exists, and if its inner map size matches the desired maglev table size ("M" parameter), so that we can delete and recreate it in case of a mismatch. The lbmap.MaglevOuterMapTableSize function is reponsible for reporting to the caller if the map already exists and its inner map size. Currently, if the map exists but its empty, MaglevOuterMapTableSize will incorrectly return false (i.e. "map does not exist"), preventing lbmap.deleteMapIfMNotMatch from deleting it in case of a mismatch with the M parameter. This commit fixes this logic. Fixes: #16844 Fixes: 879f9eb Signed-off-by: Gilberto Bertin <gilberto@isovalent.com>
krishgobinath
pushed a commit
to krishgobinath/cilium
that referenced
this issue
Oct 20, 2021
When a maglev BPF map is initialized, before creating it we check if it already exists, and if its inner map size matches the desired maglev table size ("M" parameter), so that we can delete and recreate it in case of a mismatch. The lbmap.MaglevOuterMapTableSize function is reponsible for reporting to the caller if the map already exists and its inner map size. Currently, if the map exists but its empty, MaglevOuterMapTableSize will incorrectly return false (i.e. "map does not exist"), preventing lbmap.deleteMapIfMNotMatch from deleting it in case of a mismatch with the M parameter. This commit fixes this logic. Fixes: cilium#16844 Fixes: 879f9eb Signed-off-by: Gilberto Bertin <gilberto@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
CI failure
I observed the failure in gke presubmit unit test while merging the oss cilium with gke internal one:
I was able to reproduce this on my local setup:
@pchaigno was able to reproduce this failure on his setup, and found out the current CI skipped this test since the test VM had an old kernel(4.9).
The kernel I am using is :5.10.40-1rodete1-amd64.
I am also attaching the trace file here.
trace3.txt
The text was updated successfully, but these errors were encountered: