Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs, kpr, maglev: Move Maglev out of beta #19541

Merged
merged 1 commit into from Jun 29, 2023
Merged

docs, kpr, maglev: Move Maglev out of beta #19541

merged 1 commit into from Jun 29, 2023

Conversation

borkmann
Copy link
Member

see commit msg.

@borkmann borkmann added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Apr 22, 2022
@borkmann borkmann requested review from aditighag and a team April 22, 2022 16:14
@borkmann borkmann requested a review from a team as a code owner April 22, 2022 16:14
@borkmann borkmann requested a review from qmonnet April 22, 2022 16:14
@borkmann borkmann mentioned this pull request Apr 22, 2022
Merged
aditighag
aditighag reviewed Apr 22, 2022
View reviewed changes
Copy link
Member

@aditighag aditighag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much experience working with Maglev, but I see these issues currently open that stand out -
#19260
#18744 (needs more triaging/information)
#19453 (possibly kernel regression?)

@borkmann Do you mind taking a look at these issues again against the backdrop of promoting Maglev to stable?

@borkmann
Copy link
Member Author

borkmann commented Apr 22, 2022 •
edited

#19260

I'll take a look (but it's more of a hostport issue the way it's pushing down svcs).

#18744 (needs more triaging/information)

Needs more info indeed, and reporter also runs with DSR, not clear if related.

#19453 (possibly kernel regression?)

Yes, that is a virtio_net kernel issue, nothing to do with Maglev.

brb
brb approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@brb brb left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Judging from user reports the feature has seen a fair amount of usage.

@github-actions
Copy link

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label May 28, 2022
@brb
Copy link
Member

brb commented May 30, 2022

@borkmann I think we should revive this PR for v1.12, i.e. to mark Maglev as stable.

@brb brb added the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label May 30, 2022
@github-actions github-actions bot removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label May 31, 2022
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Jul 1, 2022
@aanm aanm marked this pull request as draft July 6, 2022 12:01
@github-actions github-actions bot removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Jul 16, 2022
@github-actions
Copy link

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Aug 27, 2022
@qmonnet qmonnet added pinned These issues are not marked stale by our issue bot. and removed stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. labels Aug 31, 2022
@qmonnet
Copy link
Member

qmonnet commented Apr 17, 2023

@borkmann Should this be completed for v1.14?

@borkmann
cilium, docs: Move Maglev out of beta state
7854600 
It has seen enough production exposure over the years and there are no
known issues atm.

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
@borkmann borkmann added needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch and removed dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. labels Jun 29, 2023
@borkmann borkmann marked this pull request as ready for review June 29, 2023 12:09
@borkmann borkmann requested review from a team as code owners June 29, 2023 12:09
@borkmann
Copy link
Member Author

@borkmann Should this be completed for v1.14?

Recently also came up here https://cilium.slack.com/archives/C1MATJ5U5/p1688036113399879 . I've revived the PR so we can merge it.

@borkmann borkmann requested a review from xmulligan June 29, 2023 12:11
xmulligan
xmulligan reviewed Jun 29, 2023
View reviewed changes
Documentation/community/roadmap.rst
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add this to the table above under "eBPF networking"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this is a subfeature of Kube-proxy Replacement and Load Balancing, I don't think it would be the right place to list there.

@borkmann borkmann merged commit 893c530 into main Jun 29, 2023
40 checks passed
@borkmann borkmann deleted the pr/docs-maglev branch June 29, 2023 13:19
@joamaki joamaki mentioned this pull request Jul 5, 2023
Merged
23 tasks
@joamaki joamaki added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jul 5, 2023
@jibi jibi added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Jul 10, 2023
@joestringer joestringer mentioned this pull request Jul 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditighag aditighag aditighag left review comments

@xmulligan xmulligan xmulligan left review comments

@brb brb brb approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. pinned These issues are not marked stale by our issue bot. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@borkmann @brb @qmonnet @aditighag @xmulligan @jibi @joamaki