Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gateway-api: Bump version to v0.6.0 #22680

Merged
merged 5 commits into from Feb 23, 2023
Merged

gateway-api: Bump version to v0.6.0 #22680

merged 5 commits into from Feb 23, 2023

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Dec 12, 2022 •
edited

Description

This PR is to bump gateway-api version to v0.6.0, which includes the below changes:

  • Change API version for ReferenceGrant to v1beta1
  • Rename HTTPRequestHeaderFilter to HTTPHeaderFilter
  • Update Gateway status to Programmed and Accepted
  • Add support for http redirect filter
  • Add support for response header filter
  • Add validation for RouteDestinationPortMatching
  • Update ConformanceTest to follow the upstream structure

Full changelog can be found in the below link https://github.com/kubernetes-sigs/gateway-api/releases/tag/v0.6.0

Testing

Testing was done by running the whole conformance suite with below command.

$ go test -v ./operator/pkg/gateway-api --gateway-class cilium --supported-features ReferenceGrant,TLSRoute,HTTPRouteQueryParamMatching,HTTPRouteMethodMatching,HTTPResponseHeaderModification,RouteDestinationPortMatching,GatewayClassObservedGenerationBump  -test.run "TestConformance"

image

Running conformance tests with all features 
$ go test -v ./operator/pkg/gateway-api --gateway-class cilium --supported-features ReferenceGrant,TLSRoute,HTTPRouteQueryParamMatching,HTTPRouteMethodMatching,HTTPResponseHeaderModification,RouteDestinationPortMatching,GatewayClassObservedGenerationBump -test.run "TestConformance"
--- PASS: TestConformance (42.82s)
    --- PASS: TestConformance/GatewayInvalidRouteKind (1.08s)
        --- PASS: TestConformance/GatewayInvalidRouteKind/Gateway_listener_should_have_a_false_ResolvedRefs_condition_with_reason_InvalidRouteKinds_and_no_supportedKinds (1.01s)
        --- PASS: TestConformance/GatewayInvalidRouteKind/Gateway_listener_should_have_a_false_ResolvedRefs_condition_with_reason_InvalidRouteKinds_and_HTTPRoute_must_be_put_in_the_supportedKinds (0.00s)
    --- PASS: TestConformance/GatewayInvalidTLSConfiguration (0.15s)
        --- PASS: TestConformance/GatewayInvalidTLSConfiguration/Nonexistent_secret_referenced_as_CertificateRef_in_a_Gateway_listener (0.01s)
        --- PASS: TestConformance/GatewayInvalidTLSConfiguration/Malformed_secret_referenced_as_CertificateRef_in_a_Gateway_listener (1.01s)
        --- PASS: TestConformance/GatewayInvalidTLSConfiguration/Unsupported_kind_resource_referenced_as_CertificateRef_in_a_Gateway_listener (1.01s)
        --- PASS: TestConformance/GatewayInvalidTLSConfiguration/Unsupported_group_resource_referenced_as_CertificateRef_in_a_Gateway_listener (1.01s)
    --- PASS: TestConformance/GatewaySecretInvalidReferenceGrant (0.21s)
        --- PASS: TestConformance/GatewaySecretInvalidReferenceGrant/Gateway_listener_should_have_a_false_ResolvedRefs_condition_with_reason_RefNotPermitted (0.01s)
    --- PASS: TestConformance/GatewaySecretMissingReferenceGrant (1.04s)
        --- PASS: TestConformance/GatewaySecretMissingReferenceGrant/Gateway_listener_should_have_a_false_ResolvedRefs_condition_with_reason_RefNotPermitted (1.02s)
    --- PASS: TestConformance/GatewaySecretReferenceGrantAllInNamespace (1.08s)
        --- PASS: TestConformance/GatewaySecretReferenceGrantAllInNamespace/Gateway_listener_should_have_a_true_ResolvedRefs_condition_and_a_true_Programmed_condition (1.01s)
    --- PASS: TestConformance/GatewaySecretReferenceGrantSpecific (1.07s)
        --- PASS: TestConformance/GatewaySecretReferenceGrantSpecific/Gateway_listener_should_have_a_true_ResolvedRefs_condition_and_a_true_Programmed_condition (1.01s)
    --- PASS: TestConformance/HTTPRouteCrossNamespace (1.04s)
        --- PASS: TestConformance/HTTPRouteCrossNamespace/Simple_HTTP_request_should_reach_web-backend (1.01s)
    --- PASS: TestConformance/HTTPRouteDisallowedKind (1.09s)
        --- PASS: TestConformance/HTTPRouteDisallowedKind/Route_should_not_have_Parents_set_in_status (0.00s)
        --- PASS: TestConformance/HTTPRouteDisallowedKind/Gateway_should_have_0_Routes_attached (0.00s)
    --- PASS: TestConformance/HTTPExactPathMatching (0.04s)
        --- PASS: TestConformance/HTTPExactPathMatching/3_request_to_'/one/example'_should_receive_a_404 (1.00s)
        --- PASS: TestConformance/HTTPExactPathMatching/4_request_to_'/two/'_should_receive_a_404 (1.00s)
        --- PASS: TestConformance/HTTPExactPathMatching/2_request_to_'/'_should_receive_a_404 (1.00s)
        --- PASS: TestConformance/HTTPExactPathMatching/0_request_to_'/one'_should_go_to_infra-backend-v1 (1.01s)
        --- PASS: TestConformance/HTTPExactPathMatching/1_request_to_'/two'_should_go_to_infra-backend-v2 (1.01s)
    --- PASS: TestConformance/HTTPRouteHeaderMatching (0.04s)
        --- PASS: TestConformance/HTTPRouteHeaderMatching/5_request_to_'/'_with_headers_should_receive_a_404 (0.00s)
        --- PASS: TestConformance/HTTPRouteHeaderMatching/4_request_to_'/'_with_headers_should_receive_a_404 (0.00s)
        --- PASS: TestConformance/HTTPRouteHeaderMatching/10_request_to_'/'_with_headers_should_receive_a_404 (0.00s)
        --- PASS: TestConformance/HTTPRouteHeaderMatching/0_request_to_'/'_with_headers_should_go_to_infra-backend-v1 (1.00s)
        --- PASS: TestConformance/HTTPRouteHeaderMatching/1_request_to_'/'_with_headers_should_go_to_infra-backend-v2 (1.00s)
        --- PASS: TestConformance/HTTPRouteHeaderMatching/9_request_to_'/'_with_headers_should_go_to_infra-backend-v2 (1.00s)
        --- PASS: TestConformance/HTTPRouteHeaderMatching/3_request_to_'/'_with_headers_should_go_to_infra-backend-v2 (1.00s)
        --- PASS: TestConformance/HTTPRouteHeaderMatching/2_request_to_'/'_with_headers_should_go_to_infra-backend-v1 (1.00s)
        --- PASS: TestConformance/HTTPRouteHeaderMatching/7_request_to_'/'_with_headers_should_go_to_infra-backend-v1 (1.00s)
        --- PASS: TestConformance/HTTPRouteHeaderMatching/6_request_to_'/'_with_headers_should_go_to_infra-backend-v1 (1.01s)
        --- PASS: TestConformance/HTTPRouteHeaderMatching/8_request_to_'/'_with_headers_should_go_to_infra-backend-v2 (1.00s)
    --- PASS: TestConformance/HTTPRouteHostnameIntersection (5.21s)
        --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames (5.02s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/11_request_to_'foo.wildcard.io/non-matching-prefix'_should_receive_a_404 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/1_request_to_'non.matching.com/s1'_should_receive_a_404 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/3_request_to_'foo.wildcard.io/s1'_should_receive_a_404 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/13_request_to_'non.matching.com/s3'_should_receive_a_404 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/22_request_to_'very.specific.com/s4'_should_receive_a_404 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/23_request_to_'foo.anotherwildcard.io/non-matching-prefix'_should_receive_a_404 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/14_request_to_'foo.specific.com/s3'_should_receive_a_404 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/16_request_to_'very.specific.com/non-matching-prefix'_should_receive_a_404 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/8_request_to_'non.matching.com/s2'_should_receive_a_404 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/20_request_to_'anotherwildcard.io/s4'_should_receive_a_404 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/21_request_to_'foo.wildcard.io/s4'_should_receive_a_404 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/10_request_to_'very.specific.com/s2'_should_receive_a_404 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/4_request_to_'very.specific.com/non-matching-prefix'_should_receive_a_404 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/9_request_to_'wildcard.io/s2'_should_receive_a_404 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/2_request_to_'foo.nonmatchingwildcard.io/s1'_should_receive_a_404 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/15_request_to_'foo.wildcard.io/s3'_should_receive_a_404 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/19_request_to_'foo.bar.anotherwildcard.io/s4'_should_go_to_infra-backend-v1 (0.01s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/18_request_to_'bar.anotherwildcard.io/s4'_should_go_to_infra-backend-v1 (0.01s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/17_request_to_'foo.anotherwildcard.io/s4'_should_go_to_infra-backend-v1 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/0_request_to_'very.specific.com/s1'_should_go_to_infra-backend-v1 (0.01s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/6_request_to_'bar.wildcard.io/s2'_should_go_to_infra-backend-v2 (0.01s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/5_request_to_'foo.wildcard.io/s2'_should_go_to_infra-backend-v2 (0.01s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/7_request_to_'foo.bar.wildcard.io/s2'_should_go_to_infra-backend-v2 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/12_request_to_'very.specific.com/s3'_should_go_to_infra-backend-v3 (0.01s)
        --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_not_intersect_with_listener_hostnames (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_not_intersect_with_listener_hostnames/0_request_to_'specific.but.wrong.com/s5'_should_receive_a_404 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_not_intersect_with_listener_hostnames/1_request_to_'wildcard.io/s5'_should_receive_a_404 (0.00s)
    --- PASS: TestConformance/HTTPRouteInvalidNonExistentBackendRef (1.07s)
        --- PASS: TestConformance/HTTPRouteInvalidNonExistentBackendRef/HTTPRoute_with_only_a_nonexistent_BackendRef_has_a_ResolvedRefs_Condition_with_status_False_and_Reason_BackendNotFound (0.03s)
        --- PASS: TestConformance/HTTPRouteInvalidNonExistentBackendRef/HTTP_Request_to_invalid_nonexistent_backend_receive_a_500 (1.00s)
    --- PASS: TestConformance/HTTPRouteInvalidBackendRefUnknownKind (0.05s)
        --- PASS: TestConformance/HTTPRouteInvalidBackendRefUnknownKind/HTTPRoute_with_Invalid_Kind_has_a_ResolvedRefs_Condition_with_status_False_and_Reason_InvalidKind (0.00s)
        --- PASS: TestConformance/HTTPRouteInvalidBackendRefUnknownKind/HTTP_Request_to_invalid_backend_with_invalid_Kind_receives_a_500 (0.00s)
    --- PASS: TestConformance/HTTPRouteInvalidCrossNamespaceBackendRef (0.04s)
        --- PASS: TestConformance/HTTPRouteInvalidCrossNamespaceBackendRef/HTTPRoute_with_a_cross-namespace_BackendRef_and_no_ReferenceGrant_has_a_ResolvedRefs_Condition_with_status_False_and_Reason_RefNotPermitted (0.00s)
        --- PASS: TestConformance/HTTPRouteInvalidCrossNamespaceBackendRef/HTTP_Request_to_invalid_cross-namespace_backend_must_receive_a_500 (0.00s)
    --- PASS: TestConformance/HTTPRouteInvalidCrossNamespaceParentRef (0.03s)
        --- PASS: TestConformance/HTTPRouteInvalidCrossNamespaceParentRef/Route_should_not_have_Parents_set_in_status (0.01s)
        --- PASS: TestConformance/HTTPRouteInvalidCrossNamespaceParentRef/Gateway_should_have_0_Routes_attached (0.01s)
    --- PASS: TestConformance/HTTPRouteInvalidParentRefNotMatchingListenerPort (1.03s)
        --- PASS: TestConformance/HTTPRouteInvalidParentRefNotMatchingListenerPort/HTTPRoute_with_no_matching_port_in_ParentRef_has_an_Accepted_Condition_with_status_False_and_Reason_NoMatchingParent (1.01s)
        --- PASS: TestConformance/HTTPRouteInvalidParentRefNotMatchingListenerPort/Route_should_not_have_Parents_accepted_in_status (0.00s)
        --- PASS: TestConformance/HTTPRouteInvalidParentRefNotMatchingListenerPort/Gateway_should_have_0_Routes_attached (0.00s)
    --- PASS: TestConformance/HTTPRouteListenerHostnameMatching (3.15s)
        --- PASS: TestConformance/HTTPRouteListenerHostnameMatching/6_request_to_'foo.com/'_should_receive_a_404 (0.00s)
        --- PASS: TestConformance/HTTPRouteListenerHostnameMatching/7_request_to_'no.matching.host/'_should_receive_a_404 (0.00s)
        --- PASS: TestConformance/HTTPRouteListenerHostnameMatching/2_request_to_'baz.bar.com/'_should_go_to_infra-backend-v3 (0.00s)
        --- PASS: TestConformance/HTTPRouteListenerHostnameMatching/5_request_to_'multiple.prefixes.foo.com/'_should_go_to_infra-backend-v3 (0.00s)
        --- PASS: TestConformance/HTTPRouteListenerHostnameMatching/3_request_to_'boo.bar.com/'_should_go_to_infra-backend-v3 (0.00s)
        --- PASS: TestConformance/HTTPRouteListenerHostnameMatching/1_request_to_'foo.bar.com/'_should_go_to_infra-backend-v2 (0.00s)
        --- PASS: TestConformance/HTTPRouteListenerHostnameMatching/4_request_to_'multiple.prefixes.bar.com/'_should_go_to_infra-backend-v3 (0.00s)
        --- PASS: TestConformance/HTTPRouteListenerHostnameMatching/0_request_to_'bar.com/'_should_go_to_infra-backend-v1 (0.00s)
    --- PASS: TestConformance/HTTPRouteMatchingAcrossRoutes (0.08s)
        --- PASS: TestConformance/HTTPRouteMatchingAcrossRoutes/2_request_to_'example.net/example'_should_go_to_infra-backend-v1 (0.00s)
        --- PASS: TestConformance/HTTPRouteMatchingAcrossRoutes/0_request_to_'example.com/'_should_go_to_infra-backend-v1 (0.00s)
        --- PASS: TestConformance/HTTPRouteMatchingAcrossRoutes/1_request_to_'example.com/example'_should_go_to_infra-backend-v1 (0.00s)
        --- PASS: TestConformance/HTTPRouteMatchingAcrossRoutes/5_request_to_'example.net/v2'_should_go_to_infra-backend-v1 (0.00s)
        --- PASS: TestConformance/HTTPRouteMatchingAcrossRoutes/3_request_to_'example.com/example'_with_headers_should_go_to_infra-backend-v1 (0.00s)
        --- PASS: TestConformance/HTTPRouteMatchingAcrossRoutes/7_request_to_'example.com/'_with_headers_should_go_to_infra-backend-v2 (1.00s)
        --- PASS: TestConformance/HTTPRouteMatchingAcrossRoutes/4_request_to_'example.com/v2'_should_go_to_infra-backend-v2 (1.00s)
        --- PASS: TestConformance/HTTPRouteMatchingAcrossRoutes/6_request_to_'example.com/v2/example'_should_go_to_infra-backend-v2 (1.01s)
    --- PASS: TestConformance/HTTPRouteMatching (0.03s)
        --- PASS: TestConformance/HTTPRouteMatching/0_request_to_'/'_should_go_to_infra-backend-v1 (1.00s)
        --- PASS: TestConformance/HTTPRouteMatching/2_request_to_'/'_with_headers_should_go_to_infra-backend-v1 (1.00s)
        --- PASS: TestConformance/HTTPRouteMatching/1_request_to_'/example'_should_go_to_infra-backend-v1 (1.00s)
        --- PASS: TestConformance/HTTPRouteMatching/4_request_to_'/v2/example'_should_go_to_infra-backend-v2 (1.00s)
        --- PASS: TestConformance/HTTPRouteMatching/5_request_to_'/'_with_headers_should_go_to_infra-backend-v2 (1.01s)
        --- PASS: TestConformance/HTTPRouteMatching/3_request_to_'/v2'_should_go_to_infra-backend-v2 (1.01s)
    --- PASS: TestConformance/HTTPRouteMethodMatching (0.03s)
        --- PASS: TestConformance/HTTPRouteMethodMatching/2_request_to_'/'_should_receive_a_404 (1.00s)
        --- PASS: TestConformance/HTTPRouteMethodMatching/0_request_to_'/'_should_go_to_infra-backend-v1 (1.00s)
        --- PASS: TestConformance/HTTPRouteMethodMatching/1_request_to_'/'_should_go_to_infra-backend-v2 (1.00s)
    --- PASS: TestConformance/HTTPRoutePartiallyInvalidViaInvalidReferenceGrant (1.06s)
        --- PASS: TestConformance/HTTPRoutePartiallyInvalidViaInvalidReferenceGrant/HTTPRoute_with_BackendRef_in_another_namespace_and_no_ReferenceGrant_covering_the_Service_has_a_ResolvedRefs_Condition_with_status_False_and_Reason_RefNotPermitted (0.00s)
        --- PASS: TestConformance/HTTPRoutePartiallyInvalidViaInvalidReferenceGrant/HTTP_Request_to_invalid_backend_with_missing_referenceGrant_should_receive_a_500 (1.00s)
        --- PASS: TestConformance/HTTPRoutePartiallyInvalidViaInvalidReferenceGrant/HTTP_Request_to_valid_sibling_backend_should_succeed (0.00s)
    --- PASS: TestConformance/HTTPRouteQueryParamMatching (0.03s)
        --- PASS: TestConformance/HTTPRouteQueryParamMatching/7_request_to_'/?animal=dog'_should_receive_a_404 (1.00s)
        --- PASS: TestConformance/HTTPRouteQueryParamMatching/6_request_to_'/?color=blue'_should_receive_a_404 (1.00s)
        --- PASS: TestConformance/HTTPRouteQueryParamMatching/9_request_to_'/'_should_receive_a_404 (1.00s)
        --- PASS: TestConformance/HTTPRouteQueryParamMatching/8_request_to_'/?animal=whaledolphin'_should_receive_a_404 (1.00s)
        --- PASS: TestConformance/HTTPRouteQueryParamMatching/1_request_to_'/?animal=dolphin'_should_go_to_infra-backend-v2 (1.00s)
        --- PASS: TestConformance/HTTPRouteQueryParamMatching/3_request_to_'/?ANIMAL=Whale'_should_go_to_infra-backend-v3 (1.01s)
        --- PASS: TestConformance/HTTPRouteQueryParamMatching/4_request_to_'/?animal=whale&otherparam=irrelevant'_should_go_to_infra-backend-v1 (1.01s)
        --- PASS: TestConformance/HTTPRouteQueryParamMatching/2_request_to_'/?animal=dolphin&color=blue'_should_go_to_infra-backend-v3 (1.01s)
        --- PASS: TestConformance/HTTPRouteQueryParamMatching/5_request_to_'/?animal=dolphin&color=yellow'_should_go_to_infra-backend-v2 (1.01s)
        --- PASS: TestConformance/HTTPRouteQueryParamMatching/0_request_to_'/?animal=whale'_should_go_to_infra-backend-v1 (1.01s)
    --- PASS: TestConformance/HTTPRouteReferenceGrant (1.09s)
        --- PASS: TestConformance/HTTPRouteReferenceGrant/Simple_HTTP_request_should_reach_web-backend (1.00s)
    --- PASS: TestConformance/HTTPRouteRequestHeaderModifier (0.04s)
        --- PASS: TestConformance/HTTPRouteRequestHeaderModifier/0_request_to_'/set'_with_headers_should_go_to_infra-backend-v1 (1.00s)
        --- PASS: TestConformance/HTTPRouteRequestHeaderModifier/2_request_to_'/add'_with_headers_should_go_to_infra-backend-v1 (1.00s)
        --- PASS: TestConformance/HTTPRouteRequestHeaderModifier/4_request_to_'/remove'_with_headers_should_go_to_infra-backend-v1 (1.00s)
        --- PASS: TestConformance/HTTPRouteRequestHeaderModifier/3_request_to_'/add'_with_headers_should_go_to_infra-backend-v1 (1.00s)
        --- PASS: TestConformance/HTTPRouteRequestHeaderModifier/5_request_to_'/multiple'_with_headers_should_go_to_infra-backend-v1 (1.01s)
        --- PASS: TestConformance/HTTPRouteRequestHeaderModifier/1_request_to_'/set'_with_headers_should_go_to_infra-backend-v1 (1.01s)
        --- PASS: TestConformance/HTTPRouteRequestHeaderModifier/6_request_to_'/case-insensitivity'_with_headers_should_go_to_infra-backend-v1 (1.01s)
    --- PASS: TestConformance/HTTPRouteResponseHeaderModifier (0.04s)
        --- PASS: TestConformance/HTTPRouteResponseHeaderModifier/0_request_to_'/set'_should_go_to_infra-backend-v1 (1.00s)
        --- PASS: TestConformance/HTTPRouteResponseHeaderModifier/2_request_to_'/add'_should_go_to_infra-backend-v1 (1.00s)
        --- PASS: TestConformance/HTTPRouteResponseHeaderModifier/1_request_to_'/set'_should_go_to_infra-backend-v1 (1.00s)
        --- PASS: TestConformance/HTTPRouteResponseHeaderModifier/3_request_to_'/add'_should_go_to_infra-backend-v1 (1.00s)
        --- PASS: TestConformance/HTTPRouteResponseHeaderModifier/4_request_to_'/remove'_should_go_to_infra-backend-v1 (1.00s)
        --- PASS: TestConformance/HTTPRouteResponseHeaderModifier/6_request_to_'/case-insensitivity'_should_go_to_infra-backend-v1 (1.00s)
        --- PASS: TestConformance/HTTPRouteResponseHeaderModifier/5_request_to_'/multiple'_should_go_to_infra-backend-v1 (1.01s)
    --- PASS: TestConformance/HTTPRouteSimpleSameNamespace (1.04s)
        --- PASS: TestConformance/HTTPRouteSimpleSameNamespace/Simple_HTTP_request_should_reach_infra-backend (1.00s)
PASS
ok      github.com/cilium/cilium/operator/pkg/gateway-api       42.851s

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 12, 2022
@sayboras sayboras added dont-merge/preview-only Only for preview or testing, don't merge it. area/servicemesh GH issues or PRs regarding servicemesh release-note/misc This PR makes changes that have no direct user impact. labels Dec 12, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 12, 2022
@sayboras sayboras force-pushed the tam/gateway-0.6.0 branch 5 times, most recently from d16551f to 9688f2c Compare December 19, 2022 06:31
@sayboras sayboras removed the dont-merge/preview-only Only for preview or testing, don't merge it. label Dec 19, 2022
@sayboras sayboras force-pushed the tam/gateway-0.6.0 branch 2 times, most recently from 4796665 to 2585c4c Compare December 21, 2022 14:29
@sayboras sayboras force-pushed the tam/gateway-0.6.0 branch 5 times, most recently from 2ddc550 to 1491d91 Compare January 11, 2023 12:40
@sayboras sayboras marked this pull request as ready for review January 11, 2023 12:44
@sayboras sayboras requested review from a team as code owners January 11, 2023 12:44
@sayboras sayboras mentioned this pull request Jan 11, 2023
Closed
8 tasks
@sayboras
Copy link
Member Author

/test

@sayboras
Copy link
Member Author

Removed operator required review team, as recently servicemesh is taking over the packages in this PR

#23844

youngnick
youngnick approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one small nit about isValidPem.

operator/pkg/gateway-api/gateway_reconcile.go Show resolved Hide resolved
@sayboras sayboras force-pushed the tam/gateway-0.6.0 branch 2 times, most recently from 1a6d478 to 77e8035 Compare February 22, 2023 09:15
@sayboras
gateway-api: Bump the version to v0.6.0
6a059c0 
This commit is to bump gateway-api version to v0.6.0, and adjust the
implementation accordingly.

- Change API version for ReferenceGrant to v1beta1
- Rename HTTPRequestHeaderFilter to HTTPHeaderFilter
- Update Gateway status to Programmed and Accepted
- Update ConformanceTest to follow the upstream version

Full changelog can be found in the below link
https://github.com/kubernetes-sigs/gateway-api/releases/tag/v0.6.0

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras
gateway-api: Add support for HTTPResponseHeaderModification
abdb92a 
This commit is to make sure that we have the support for response header
filter. The conformance test is enabled accordingly.

Kindly note this Response header filter is still in experimental.

Relates: cilium#21924
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras
gateway-api: Add support for RouteDestinationPortMatching
9e21c71 
This commit is to make sure that we have the support RouteDestinationPortMatching
feature. The conformance test is enabled accordingly.

Relates: kubernetes-sigs/gateway-api#1591
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras
gateway-api: Add support for Redirect filter
7edbde7 
This commit is to make sure that we have the support HTTP Redirect filter
feature, which is enabled by default in conformance test.

Relates: cilium#21924
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras
gha: Update Gateway API Conformance test
63b386c 
This commit is to update GHA Gateway API conformance test as per below:

- Use experimental CRDs mainly for running tests for all features.
- Remove -debug flag as it's too verbose.
- Limit number of concurrency test from default (e.g. 8) to 4 to minimize
  overlapping between the tests.
- Enable GatewayClassObservedGenerationBump feature.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras
Copy link
Member Author

/test

rolinh
rolinh approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@rolinh rolinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vendor changes lgtm.

@sayboras sayboras mentioned this pull request Feb 22, 2023
Merged
@sayboras
Copy link
Member Author

/test-1.25-4.19

@sayboras
Copy link
Member Author

/test-1.16-4.19

@sayboras
Copy link
Member Author

sayboras commented Feb 22, 2023 •
edited

/test-1.16-4.19

Re-run due to environment issue

@sayboras
Copy link
Member Author

Reviews are in, all CI jobs are passed, ci-l4lb and ci-verifier are not required.

Marking this ready to merge.

@sayboras sayboras added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 23, 2023
@sayboras sayboras merged commit efbe2d8 into cilium:master Feb 23, 2023
@sayboras sayboras deleted the tam/gateway-0.6.0 branch February 23, 2023 01:39
@sayboras sayboras mentioned this pull request Feb 24, 2023
Closed
@sayboras sayboras mentioned this pull request May 14, 2023
Closed
2 tasks
@sayboras sayboras mentioned this pull request May 14, 2023
Merged
sayboras added a commit to sayboras/cilium that referenced this pull request May 15, 2023
@sayboras
docs: Update gateway-api version to v0.6.1
d03df31 
After the PR cilium#22680, the minimum Gateway API supported version is
v0.6.x. Older version will not work due to changes in API version of
CRDs.

Relates: cilium#22680
Fixes: cilium#25377

Signed-off-by: Tam Mach <tam.mach@cilium.io>
aditighag pushed a commit that referenced this pull request May 17, 2023
@sayboras @aditighag
docs: Update gateway-api version to v0.6.1
1672631 
After the PR #22680, the minimum Gateway API supported version is
v0.6.x. Older version will not work due to changes in API version of
CRDs.

Relates: #22680
Fixes: #25377

Signed-off-by: Tam Mach <tam.mach@cilium.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolinh rolinh rolinh approved these changes

@nbusseneau nbusseneau nbusseneau approved these changes

@youngnick youngnick youngnick approved these changes

Assignees
No one assigned
Labels
area/servicemesh GH issues or PRs regarding servicemesh ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sayboras @rolinh @nbusseneau @youngnick @tklauser