New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update gateway-api version to v0.6.1 #25439
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
May 14, 2023
sayboras
added
area/documentation
Impacts the documentation, including textual changes, sphinx, or other doc generation code.
release-note/misc
This PR makes changes that have no direct user impact.
labels
May 14, 2023
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
May 14, 2023
The changes are limited to docs, full CI is not required. |
2 tasks
raphink
reviewed
May 15, 2023
After the PR cilium#22680, the minimum Gateway API supported version is v0.6.x. Older version will not work due to changes in API version of CRDs. Relates: cilium#22680 Fixes: cilium#25377 Signed-off-by: Tam Mach <tam.mach@cilium.io>
Without ReferenceGrant v1beta1, we will have below error in the operator upon starting up. The existing provisioned resource will continue to work as usual, but new resources will not be handled properly. ``` 2023-05-10T13:49:48.691595989Z level=error msg="Unable to start controller" controller=gateway-api error="failed to wait for referencegrant caches to sync: timed out waiting for cache to be synced" subsys=gateway-controller ``` Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
force-pushed
the
tam/gateway-0.6.x-docs
branch
from
May 15, 2023 08:58
0c7a675
to
21afd35
Compare
qmonnet
approved these changes
May 15, 2023
youngnick
approved these changes
May 16, 2023
Required reviews are in, this PR is limited to documentation changes, full CI is not required, marking this ready to merge. |
sayboras
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/documentation
Impacts the documentation, including textual changes, sphinx, or other doc generation code.
area/servicemesh
GH issues or PRs regarding servicemesh
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/misc
This PR makes changes that have no direct user impact.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After PR #22680, the minimum Gateway API supported version is v0.6.x. The older version will not work due to changes in the API version of CRDs.
Relates: #22680
Fixes: #25377