Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update gateway-api version to v0.6.1 #25439

Merged
merged 2 commits into from May 17, 2023

Conversation

sayboras
Copy link
Member

After PR #22680, the minimum Gateway API supported version is v0.6.x. The older version will not work due to changes in the API version of CRDs.

Relates: #22680
Fixes: #25377

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 14, 2023
@sayboras sayboras added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels May 14, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 14, 2023
@sayboras sayboras marked this pull request as ready for review May 14, 2023 12:08
@sayboras sayboras requested review from a team as code owners May 14, 2023 12:08
@sayboras
Copy link
Member Author

The changes are limited to docs, full CI is not required.

After the PR cilium#22680, the minimum Gateway API supported version is
v0.6.x. Older version will not work due to changes in API version of
CRDs.

Relates: cilium#22680
Fixes: cilium#25377

Signed-off-by: Tam Mach <tam.mach@cilium.io>
Without ReferenceGrant v1beta1, we will have below error in the operator
upon starting up. The existing provisioned resource will continue to work
as usual, but new resources will not be handled properly.

```
2023-05-10T13:49:48.691595989Z level=error msg="Unable to start controller" controller=gateway-api error="failed to wait for referencegrant caches to sync: timed out waiting for cache to be synced" subsys=gateway-controller
```

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras added the area/servicemesh GH issues or PRs regarding servicemesh label May 15, 2023
@sayboras
Copy link
Member Author

Required reviews are in, this PR is limited to documentation changes, full CI is not required, marking this ready to merge.

@sayboras sayboras added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 16, 2023
@aditighag aditighag merged commit 59dbe19 into cilium:main May 17, 2023
36 checks passed
@sayboras sayboras deleted the tam/gateway-0.6.x-docs branch May 17, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/servicemesh GH issues or PRs regarding servicemesh ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gateway API: Gateway controller fails to start causing missing service
5 participants