Extend tunnel map key with ClusterID #22687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
YutaroHayakawa
added
sig/datapath
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
YutaroHayakawa
force-pushed
the
yutaro/clustermesh-overlapping-podcidr-oss-tunnel-map
branch
from
44dc08d
to
341dfe5
Compare
YutaroHayakawa
requested review from
dylandreimerink,
NikAleksandrov and
ldelossa
YutaroHayakawa
force-pushed
the
yutaro/clustermesh-overlapping-podcidr-oss-tunnel-map
branch
from
341dfe5
to
066171e
Compare
|
Rebased on the latest master. |
ldelossa
reviewed
Jan 5, 2023
|
/test |
YutaroHayakawa
force-pushed
the
yutaro/clustermesh-overlapping-podcidr-oss-tunnel-map
branch
from
066171e
to
164b9d7
Compare
|
Fixed the conflicts with the latest master. |
|
/test |
In Cluster Mesh with overlapping PodCIDR, we have to identify remote endpoint with IP + ClusterID. Thus, we should also lookup tunnel map using IP + ClusterID. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
Implement required helpers to implement tunnel map with cluster-aware addressing. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
Modify tunnel map APIs (Set/Get/Delete/SilentDelete) to be aware of the cluster-aware addressing. Currently, there's no user interface to set non-zero ClusterID. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
Tunnel map APIs (Set/Get/Delete/SilentDelete) are implemented as a method of Map (tunnel map) struct. However, they all uses global TunnelMap valiable internally. Fix for readability and ease of tests. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
YutaroHayakawa
force-pushed
the
yutaro/clustermesh-overlapping-podcidr-oss-tunnel-map
branch
from
164b9d7
to
c36dad8
Compare
|
Rebased on the latest master. This removes the duplicated code with #22200. Also I renamed the |
|
/test Job 'Cilium-PR-K8s-1.16-kernel-4.9' failed: Click to show.Test NameFailure OutputIf it is a flake and a GitHub issue doesn't already exist to track it, comment |
|
|
/test-1.16-4.9 |
|
Multicluster / Cluster mesh hit this #23045. |
|
/ci-multicluster |
YutaroHayakawa
added
the
ready-to-merge
@YutaroHayakawa Please reopen the flake issue in such cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of the Cluster Mesh with overlapping PodCIDR support. When the remote cluster has an overlapping PodCIDR, we must identify the remote endpoint using IP + ClusterID. This PR makes the required changes for the tunnel map to realize that. Note that this PR only adds infrastructure, and currently, we don't "use" that. Please see the commits for more details.