test/Vagrantfile: Don't hide natnetwork errors #22702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit ef22668 reworked the natnetwork creations and deletions and for some obscure reason, I thought it was a good idea to dump stderr. This commit removes that bit, to show stderr in the Vagrant output. We may have a few more erroneous-looking logs (because we sometimes try to create natnetworks that already exists) but I think it's worth it to catch any actual configuration error or even to know if natnetwork existed when they shouldn't. Fixes: ef22668 ("vagrant: Don't recreate natnetworks") Signed-off-by: Paul Chaignon <paul@cilium.io>
|
/test Job 'Cilium-PR-K8s-1.16-kernel-4.9' failed: Click to show.Test NameFailure OutputIf it is a flake and a GitHub issue doesn't already exist to track it, comment |
tklauser
approved these changes
Dec 13, 2022
|
k8s-1.16-kernel-4.9 failed with flake #22739. Clearly unrelated given this change is only showing up errors, not changing logic. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit ef22668 reworked the natnetwork creations and deletions and for some obscure reason, I thought it was a good idea to dump stderr. This commit removes that bit, to show stderr in the Vagrant output. We may have a few more erroneous-looking logs (because we sometimes try to create natnetworks that already exists) but I think it's worth it to catch any actual configuration error or even to know if natnetwork existed when they shouldn't.
Fixes: #19523