vagrant: Don't recreate natnetworks #19523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are hitting issues with the natnetwork creations, both in CI and in the dev. VM setup. In both cases, it fails to create because the natnetwork apparently already exists. For the dev. VM, that happens because the removal of natnetworks sometimes fail, maybe because it's still in use while being removed. For the CI, it's unclear why it fails as a previous listing of natnetworks shows nothing. In any case, one way to work around this is to avoid recreating the natnetworks each time the VMs are booted. Instead, we can create only the natnetworks we need and delete the rest. If the creations fail, we assume it's because they already exist and ignore the failure. To be able to ignore the creation failures, we must move them outside of the Vagrant interface configuration and into a proper Shell script, which we run in a pre-provisioning step. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added
kind/bug/CI
|
/test-vagrant |
christarazi
approved these changes
Apr 21, 2022
aanm
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are hitting issues with the natnetwork creations, both in CI and in the dev. VM setup. In both cases, it fails to create because the natnetwork apparently already exists. For the dev. VM, that happens because the removal of natnetworks sometimes fail, maybe because it's still in use while being removed. For the CI, it's unclear why it fails as a previous listing of natnetworks shows nothing.
In any case, one way to work around this is to avoid recreating the natnetworks each time the VMs are booted. Instead, we can create only the natnetworks we need and delete the rest. If the creations fail, we assume it's because they already exist and ignore the failure.
To be able to ignore the creation failures, we must move them outside of the Vagrant interface configuration and into a proper Shell script, which we run in a pre-provisioning step.