Revert "build: Generate SBOM during image release" #23204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
ldelossa
force-pushed
the
ldelossa/disable-sbom
branch
from
109c083
to
6428595
Compare
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
pchaigno
approved these changes
Jan 19, 2023
|
Thanks. I think we should just revert b11a065, rather than make separate independent commits to address the issue. This way not only can we keep track of the revert w.r.t. original commit but we also remove the documentation bits, which helps protect us against potential users expecting an SBOM in release (if we don't re-enable SBOM by then). |
This reverts commit b11a065. SBOM generation in combination with updates to the GH runner broke the CI for master. This reverts SBOM CI steps until we have a more permanent fix. Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
dylandreimerink
force-pushed
the
ldelossa/disable-sbom
branch
from
139f3f8
to
0387140
Compare
nbusseneau
approved these changes
Jan 20, 2023
nbusseneau
added
the
ready-to-merge
pchaigno
approved these changes
Jan 20, 2023
nbusseneau
changed the title
|
@cilium/docs-structure ACK is not required on this one since it's a revert, marked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b11a065.
SBOM generation in combination with updates to the GH runner broke
the CI for master. This reverts SBOM CI steps until we have a more
permanent fix.
Signed-off-by: Dylan Reimerink dylan.reimerink@isovalent.com