github: do not generate SBOM from source #23161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
added
priority/high
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
aanm
added
release-note/misc
nbusseneau
approved these changes
Jan 18, 2023
aanm
force-pushed
the
pr/remove-dirs-generation-sbom
branch
from
bec93da
to
7ace532
Compare
|
What does it use if not the source? Does it just generate it from the compiled binaries? |
joestringer
approved these changes
Jan 19, 2023
ldelossa
approved these changes
Jan 19, 2023
ldelossa
force-pushed
the
pr/remove-dirs-generation-sbom
branch
from
7ace532
to
b6deb5d
Compare
michi-covalent
approved these changes
Jan 19, 2023
@joestringer In this case it will generate it from the installed packages in the image. I'm not sure if it will generate it for the cilium binaries. |
Generating SBOM from source takes a long time and due to a bug [1] it fills out the GH runner disk. Thus we will not be generating the SBOM from source until the bug is fixed. [1] kubernetes-sigs/bom#202 Fixes: b11a065 ("build: Generate SBOM during image release") Signed-off-by: André Martins <andre@cilium.io>
aanm
force-pushed
the
pr/remove-dirs-generation-sbom
branch
from
b6deb5d
to
0bc4180
Compare
|
This is likely voided by #23204. |
|
None of the test failures are caused by the modification of the workflow files. Merging... |
aanm
added
backport-pending/1.13
3 tasks
aanm
removed
the
backport-pending/1.13
aanm
added
the
backport-done/1.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generating SBOM from source takes a long time and due to a bug [1] it fills out the GH runner disk. Thus we will not be generating the SBOM from source until the bug is fixed.
[1] kubernetes-sigs/bom#202
Fixes: b11a065 ("build: Generate SBOM during image release")
Signed-off-by: André Martins andre@cilium.io