Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sockops-enable and friends #23556

Closed
brb opened this issue Feb 3, 2023 · 7 comments · Fixed by #23606
Closed

Remove sockops-enable and friends #23556

brb opened this issue Feb 3, 2023 · 7 comments · Fixed by #23606
Labels
sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.

Comments

@brb
Copy link
Member

brb commented Feb 3, 2023 •
edited

We have deprecated --sockops-enable in v1.13, and we can remove the feature in v1.14 (it's not being maintained). pkg/sockops, bpf/sockops, pkg/map/sockmap, etc can be removed, and some of the issues https://github.com/cilium/cilium/issues?q=is%3Aissue+is%3Aopen+sockops can be closed.
@brb brb added help-wanted Please volunteer for this by adding yourself as an assignee! good-first-issue Good starting point for new developers, which requires minimal understanding of Cilium. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/sockops labels Feb 3, 2023
@mohit-marathe
Copy link
Contributor

Hello @brb, can you assign this to me?

@mohit-marathe mohit-marathe mentioned this issue Feb 5, 2023
Closed
7 tasks
@brb
Copy link
Member Author

brb commented Feb 7, 2023

@mohit-marathe Sure!

@mohit-marathe mohit-marathe mentioned this issue Feb 7, 2023
Merged
7 tasks
mohit-marathe added a commit to mohit-marathe/cilium that referenced this issue Mar 17, 2023
@mohit-marathe
Remove sockops-enable and friends
0dc23d9 
This removes every occurrences of sockops and sockmap as it was deprecated in v1.13.

Fixes: cilium#23556

Signed-off-by: Mohit Marathe <mohitmarathe23@gmail.com>
mohit-marathe added a commit to mohit-marathe/cilium that referenced this issue Mar 31, 2023
@mohit-marathe
Remove sockops-enable and friends
e6b8508 
This removes every occurrences of sockops and sockmap as it was deprecated in v1.13.

Fixes: cilium#23556

Signed-off-by: Mohit Marathe <mohitmarathe23@gmail.com>
mohit-marathe added a commit to mohit-marathe/cilium that referenced this issue Apr 3, 2023
@mohit-marathe
Remove sockops-enable and friends
4c423f3 
This removes every occurrences of sockops and sockmap as it was deprecated in v1.13.

Fixes: cilium#23556

Signed-off-by: Mohit Marathe <mohitmarathe23@gmail.com>
mohit-marathe added a commit to mohit-marathe/cilium that referenced this issue Apr 4, 2023
@mohit-marathe
Remove sockops-enable and friends
ab9efc7 
This removes every occurrences of sockops and sockmap as it was deprecated in v1.13.

Fixes: cilium#23556

Signed-off-by: Mohit Marathe <mohitmarathe23@gmail.com>
aanm pushed a commit that referenced this issue Apr 4, 2023
@mohit-marathe @aanm
Remove sockops-enable and friends
87c8746 
This removes every occurrences of sockops and sockmap as it was deprecated in v1.13.

Fixes: #23556

Signed-off-by: Mohit Marathe <mohitmarathe23@gmail.com>
@qmonnet
Copy link
Member

qmonnet commented Apr 4, 2023

Reopening the issue, just so we don't forget to clean up (other) sockops-related issues. 🧹

@qmonnet qmonnet reopened this Apr 4, 2023
@qmonnet qmonnet removed help-wanted Please volunteer for this by adding yourself as an assignee! good-first-issue Good starting point for new developers, which requires minimal understanding of Cilium. labels Apr 4, 2023
@qmonnet
Copy link
Member

qmonnet commented Apr 4, 2023

We can also probably remove the label area/sockops after that.

@brb brb assigned mohit-marathe and unassigned mohit-marathe May 24, 2023
@brb
Copy link
Member Author

brb commented May 24, 2023

@qmonnet Can we close this issue and related ones?

@qmonnet
Copy link
Member

qmonnet commented May 24, 2023

@brb Yes!

@brb
Copy link
Member Author

brb commented May 24, 2023

Resolved by @mohit-marathe. Thanks! Closing the issue.

@brb brb closed this as completed May 24, 2023
This was referenced May 24, 2023
Closed
Closed
Closed
Closed
Closed
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Milestone
No milestone
3 participants
@brb @qmonnet @mohit-marathe