Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TestDummyProg() #23558

Closed
rgo3 opened this issue Feb 3, 2023 · 3 comments · Fixed by #25355
Closed

Remove TestDummyProg() #23558

rgo3 opened this issue Feb 3, 2023 · 3 comments · Fixed by #25355
Assignees
@ti-mo
Labels
pinned These issues are not marked stale by our issue bot. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.

Comments

@rgo3
Copy link
Contributor

rgo3 commented Feb 3, 2023

As a follow up to #23557 we shouldremove TestDummyProg(). Like @ti-mo mentioned in #20739 (comment)_ feature probing prog/attachtype combinations looses value if the new implementation uses bpf_link.

Instead of probing for a succeeding PROG_ATTACH we should just ask for forgiveness with the new logic in pkg/socketlb and bail out or flip flags in cases of failure.
@rgo3
Copy link
Contributor Author

rgo3 commented Feb 3, 2023

cc @ti-mo

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

This issue has been automatically marked as stale because it has not
had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Apr 5, 2023
@rgo3 rgo3 added pinned These issues are not marked stale by our issue bot. and removed stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. labels Apr 5, 2023
@squeed squeed added the sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. label Apr 5, 2023
@ti-mo ti-mo self-assigned this May 10, 2023
@ti-mo ti-mo mentioned this issue May 10, 2023
Merged
@ti-mo
Copy link
Contributor

ti-mo commented May 10, 2023

Proposal for this in #25355.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ti-mo ti-mo

Labels
pinned These issues are not marked stale by our issue bot. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bpf: migrate hand-written bpf syscalls to ebpf-go APIs ti-mo/cilium
3 participants
@squeed @ti-mo @rgo3