bpf: migrate hand-written bpf syscalls to ebpf-go APIs #25355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
ti-mo
force-pushed
the
tb/more-ebpf-maps
branch
2 times, most recently
from
62af59c
to
a43ea7a
Compare
ti-mo
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
/test |
1 similar comment
|
/test |
ti-mo
force-pushed
the
tb/more-ebpf-maps
branch
3 times, most recently
from
519a9ea
to
2591156
Compare
ti-mo
changed the title
|
/test |
nbusseneau
approved these changes
May 26, 2023
lmb
approved these changes
May 30, 2023
| return false, fmt.Errorf("unable to delete element %s from map %s: %w", key, m.name, err) | ||
| } | ||
|
|
||
| return true, nil | ||
| } | ||
|
|
||
| // SilentDelete deletes the map entry corresponding to the given key. |
There was a problem hiding this comment.
Drive by: this description doesn't tell me at all what makes the function so silent.
There was a problem hiding this comment.
Yeah, this needs to go. As you can see, the Map API is full of this sort of snowflake and unhelpful/incomplete doc. To answer your question: it skips incrementing the map's delete metric.
IMO this highlights a common problem with the design of the data model in the upper layer(s). The data (e.g. ct record) and the underlying data store (e.g. the ct map) are conflated. The bpf layer shouldn't lie about the amount of deletes it issues to the kernel, as it could mask a potential perf problem.
| Net [16]byte | ||
|
|
||
| // v4 LPM maps have 8-byte key sizes even though the 20-byte cidrKey is used | ||
| // for map ops. This hack relies on passing unsafe.Pointers to the cidrKey so |
Replace bpf.DeleteElement() by calls into ebpf.Map.Delete(). Move metrics handling into bpf.Map.delete(). Signed-off-by: Timo Beckers <timo@isovalent.com>
In order to move away from map operations implemented in pkg/bpf/bpf_linux.go, migrate Map.DumpWithCallback and friends onto ebpf-go based primitives. No changes are made to the algorithm used in DumpReliably..(). Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
…port This was moved in from the verifier tests and given a test suite of its own. Test cases based on what the agent does on startup. Signed-off-by: Timo Beckers <timo@isovalent.com>
This will be used in a follow-up commit to be executed during socketlb setup. It implements only the cgroup link/prog_attach part of TestDummyProg so it can be run once instead of on each prog/attach type probe combination. Includes a privileged test that is expected to succeed in all CI environments. Signed-off-by: Timo Beckers <timo@isovalent.com>
Builds on the APIs added in prior commits. Probing for cgroup attach support is now only done once at the start of the socketlb setup, and prog/attach type probes are now executed separately, underlyingly using APIs from ebpf-go. Signed-off-by: Timo Beckers <timo@isovalent.com>
|
/test |
|
/test-1.26-net-next |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #22693 and contains all of its commits. That one is close to being merged, so this can be rebased later.
See individual commits. Again a bit of churn, but relatively straightforward.
Fixes: #22513
Fixes: #23558