.github/workflows: run datapath complexity tests directly in VM #24117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
added
area/CI-improvement
tklauser
force-pushed
the
pr/tklauser/complexity-test-run-in-vm
branch
3 times, most recently
from
1ce02c1
to
789ed9a
Compare
tklauser
force-pushed
the
pr/tklauser/complexity-test-run-in-vm
branch
from
789ed9a
to
84ed7d1
Compare
Now that the complexity-test images are available on quay [1][2], we can use these to run the complexity tests directly within the VM instead of running a docker container with the test-verifier image. [1] cilium/little-vm-helper-images#42 [2] https://quay.io/repository/lvh-images/complexity-test Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
force-pushed
the
pr/tklauser/complexity-test-run-in-vm
branch
from
84ed7d1
to
d5214b8
Compare
|
Successful runs with test commit: https://github.com/cilium/cilium/actions/runs/4450012129?pr=24117 |
tklauser
force-pushed
the
pr/tklauser/complexity-test-run-in-vm
branch
from
d5214b8
to
cde8ee6
Compare
brlbil
approved these changes
Mar 21, 2023
tklauser
added
the
ready-to-merge
nebril
approved these changes
Mar 21, 2023
tklauser
commented
Mar 22, 2023
Comment on lines
+211
to
+212
| # workaround to use correct ip binary. TODO: this should be fixed in the complexity-test image. | ||
| rm /usr/bin/ip |
There was a problem hiding this comment.
Addressed in cilium/little-vm-helper-images#50
tklauser
added a commit
that referenced
this pull request
Mar 22, 2023
… tests Follow-up for #24117 now that the complexity-test image correctly replaces the ip binary with the one from the Cilium image, see cilium/little-vm-helper-images#50 Signed-off-by: Tobias Klauser <tobias@cilium.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the complexity-test images are available on quay [1][2], we can use these to run the complexity tests directly within the VM instead of running a docker container with the test-verifier image.
[1] cilium/little-vm-helper-images#42
[2] https://quay.io/repository/lvh-images/complexity-test