Correctly replace ip/tc binaries in complexity-test image #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid potentially installing packages we don't need. Also remove apt source lists on clean up. Signed-off-by: Tobias Klauser <tobias@cilium.io>
Signed-off-by: Tobias Klauser <tobias@cilium.io>
…mlinks In some cases the ip and tc binaries might be symlinks which in the current installation would lead to only the symlink being deleted, but not the binary it points at. This could lead to the "old" non-Cilium binaries still being present in the image. Fix this by making sure to also clean up the pointed at binary. This should allow to remove workaround such as the following: https://github.com/cilium/cilium/pull/24117/files#diff-8a97415e3b1ab63d0cbf682a195a63c178786ae792455f62f7dc523acf9f9b50R211-R212 Signed-off-by: Tobias Klauser <tobias@cilium.io>
info:
{
"orig_ref": "9aaaabaaf7abd2696df171141846a370703d7562",
"tag": "20230322.103351"
}
X-GHA-TAG: 20230322.103351
github-actions
bot
force-pushed
the
pr/tklauser/complexity-test-fix-iproute-binaries-install
branch
from
30f36b8
to
2b36f58
Compare
brb
deleted the
pr/tklauser/complexity-test-fix-iproute-binaries-install
branch
tklauser
added a commit
to cilium/cilium
that referenced
this pull request
Mar 22, 2023
… tests Follow-up for #24117 now that the complexity-test image correctly replaces the ip binary with the one from the Cilium image, see cilium/little-vm-helper-images#50 Signed-off-by: Tobias Klauser <tobias@cilium.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases the ip and tc binaries might be symlinks which in the
current installation would lead to only the symlink being deleted, but
not the binary it points at. This could lead to the "old" non-Cilium
binaries still being present in the image. Fix this by making sure to
also clean up the pointed at binary.
This should allow to remove workaround such as the following:
https://github.com/cilium/cilium/pull/24117/files#diff-8a97415e3b1ab63d0cbf682a195a63c178786ae792455f62f7dc523acf9f9b50R211-R212
See commits for details.