Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update json-mock image #24173

Merged
merged 1 commit into from Mar 10, 2023
Merged

chore: Update json-mock image #24173

merged 1 commit into from Mar 10, 2023

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Mar 5, 2023

Just replace docker.io/cilium/json-mock.* to quay.io/cilium/json-mock:v1.3.3@sha256:f26044a2b8085fcaa8146b6b8bb73556134d7ec3d5782c6a04a058c945924ca0

Fixes: #24170

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 5, 2023
@sayboras sayboras added the release-note/misc This PR makes changes that have no direct user impact. label Mar 5, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 5, 2023
@sayboras
Copy link
Member Author

sayboras commented Mar 5, 2023

/test

@sayboras sayboras marked this pull request as ready for review March 5, 2023 12:25
@sayboras sayboras requested review from a team as code owners March 5, 2023 12:25
qmonnet
qmonnet reviewed Mar 6, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to provide the motivation for the changes in the commit description. I understand the need for the update from the linked issue, but I'd summarise it here; and the reason for switch from Docker to Quay.io is not stated.

test/controlplane/services/nodeport/v1.24/state1.yaml Outdated Show resolved Hide resolved
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 6, 2023
@qmonnet qmonnet added dont-merge/bad-bot To prevent MLH from marking ready-to-merge. and removed ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Mar 6, 2023
@sayboras
chore: Update json-mock image
ca28703 
Just replace docker.io/cilium/json-mock.* to quay.io/cilium/json-mock:v1.3.3@sha256:f26044a2b8085fcaa8146b6b8bb73556134d7ec3d5782c6a04a058c945924ca0
Switching to quay.io is done as the current image in docker.io only
has amd64 build, but not arm version. It's also consistent with main
cilium image repository.

Fixes: cilium#24170
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras requested a review from qmonnet March 10, 2023 09:47
@sayboras sayboras removed the dont-merge/bad-bot To prevent MLH from marking ready-to-merge. label Mar 10, 2023
@qmonnet
Copy link
Member

qmonnet commented Mar 10, 2023

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 10, 2023
@sayboras sayboras merged commit 5c59e61 into cilium:master Mar 10, 2023
@sayboras sayboras deleted the tam/update-json-mock branch March 10, 2023 15:18
@loomkoom loomkoom mentioned this pull request Mar 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebril nebril nebril approved these changes

@YutaroHayakawa YutaroHayakawa YutaroHayakawa approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support arm64 cilium/json-mock
4 participants
@sayboras @qmonnet @nebril @YutaroHayakawa