chore: update json-mock image source in examples #31373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
lambdanis
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
joestringer
added
the
needs-backport/1.15
lambdanis
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Thank you for the fix @loomkoom! Looks good.
There are two related changes that would be nice to have - feel free to add them to your PR, but otherwise these can also be done as a follow-up by someone else:
examples/minikube/http-sw-app.yamlreferencesdocker.io/cilium/starwarsimage, which likejson-mockhas been moved toquay.io. So thestarwarsimage should be updated too.- It would be great to have the image tags updated on new releases. Cilium uses Renovate to auto-update dependencies, but
examplesdirectory is excluded by default. To get automatic updates in these examples, we should add these two files to includePaths list in Renovate config.
|
/test |
|
@loomkoom I see one check is failing because of a long commit subject: https://github.com/cilium/cilium/actions/runs/8266311327/job/22626632968?pr=31373 Could you amend the commit message? |
Replaced docker.io by quay.io pinned with current latest Docker source is deprecated. Signed-off-by: loomkoom <loomkoom@hotmail.com>
|
|
/test |
youngnick
approved these changes
Mar 21, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
sayboras
added
backport-pending/1.15
github-actions
bot
added
backport-done/1.15
This was referenced Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
docker.io/cilium/json-mockwithquay.io/cilium/json-mockpinned with current latest (1.3.8)
The docker source is deprecated and doesn't provide arm64 builds
I had issues running
examples/kubernetes-dns/dns-sw-appandexamples/minikube/http-sw-appwhen following the docs in an ARM environment:exec /bin/bash: exec format errorThis was addressed in #24173, but it seems like that fix missed these 2 examples since they didn't have an explicit version tag provided?
Fixes: #24170