Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix Rule spec document typos #24319

Merged
merged 1 commit into from Mar 16, 2023
Merged

docs: fix Rule spec document typos #24319

merged 1 commit into from Mar 16, 2023

Conversation

nrnrk
Copy link
Contributor

@nrnrk nrnrk commented Mar 12, 2023 •
edited

Fix typos in the Rule spec document

@nrnrk
docs: fix Rule spec document typos
717e402 
fix typos for natural sentences

Signed-off-by: Noriki Takahashi <noriki6t@gmail.com>
@nrnrk nrnrk requested a review from a team as a code owner March 12, 2023 18:43
@nrnrk nrnrk requested a review from nathanjsweet March 12, 2023 18:43
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 12, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Mar 12, 2023
@nathanjsweet nathanjsweet added release-note/misc This PR makes changes that have no direct user impact. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Mar 16, 2023
@aditighag aditighag merged commit a97f1f4 into cilium:master Mar 16, 2023
1 check passed
@nathanjsweet
Copy link
Member

nathanjsweet commented Mar 16, 2023 •
edited

@nrnrk
This PR had to be reverted because I forgot to run the lint and build jobs for this PR that would have told us that you need to run make generate-k8s-api generate-hubble-api generate-api and make -C Documentation update-cmdref for this change. These commands will auto-generate additional changes in other files that will also need to be part of the changes submitted.

Please resubmit your changes in a new PR after the revert PR is merged (your changes need to be submitted on top of the revert), being sure to run the above commands and submit those changes with your new PR as well. Thanks! Sorry for the mistake on our end 🙏 .

@nrnrk
Copy link
Contributor Author

nrnrk commented Mar 17, 2023 •
edited

Thank you for explanation in details. I will be sure to execute the make command and resubmit it.

@nrnrk nrnrk deleted the docs/fix_rule_spec_typo branch March 18, 2023 01:15
@nrnrk nrnrk mentioned this pull request Mar 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanjsweet nathanjsweet nathanjsweet approved these changes

Assignees
No one assigned
Labels
kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nrnrk @nathanjsweet @aditighag