Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix Rule spec document typos #24443

Merged
merged 1 commit into from
Mar 20, 2023
Merged

docs: fix Rule spec document typos #24443

merged 1 commit into from
Mar 20, 2023
+10 −10

Conversation

nrnrk
Copy link
Contributor

@nrnrk nrnrk commented Mar 18, 2023

Fix typos for natural sentences

Resubmit this PR

@nrnrk
docs: fix Rule spec document typos
0b78978 
Fix typos for natural sentences

Signed-off-by: Noriki Takahashi <noriki6t@gmail.com>
@nrnrk nrnrk requested review from a team as code owners March 18, 2023 07:31
@nrnrk nrnrk requested a review from nathanjsweet March 18, 2023 07:31
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 18, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Mar 18, 2023
@nrnrk nrnrk mentioned this pull request Mar 18, 2023
Merged
@sayboras sayboras added the release-note/misc This PR makes changes that have no direct user impact. label Mar 18, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 18, 2023
nathanjsweet
nathanjsweet approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@nathanjsweet nathanjsweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nathanjsweet nathanjsweet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 20, 2023
@aditighag
Copy link
Member

Thank you!

@aditighag aditighag merged commit 26e660c into cilium:master Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanjsweet nathanjsweet nathanjsweet approved these changes

Assignees
No one assigned
Labels
kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nrnrk @aditighag @nathanjsweet @sayboras