Break import cycles and move the datapath cell to datapath/cell.go #24337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bimmlerd
added
release-note/misc
bimmlerd
force-pushed
the
pr/bimmlerd/move-datapath-types
branch
4 times, most recently
from
4cde4c2
to
11afe7f
Compare
bimmlerd
requested review from
nbusseneau,
tommyp1ckles,
kaworu,
jrajahalme,
ti-mo,
NikAleksandrov and
nebril
nebril
approved these changes
Mar 14, 2023
ti-mo
requested changes
Mar 14, 2023
bimmlerd
force-pushed
the
pr/bimmlerd/move-datapath-types
branch
from
11afe7f
to
187724e
Compare
bimmlerd
force-pushed
the
pr/bimmlerd/move-datapath-types
branch
from
187724e
to
96f0af1
Compare
nbusseneau
approved these changes
Mar 14, 2023
ti-mo
approved these changes
Mar 15, 2023
jrajahalme
approved these changes
Mar 15, 2023
NikAleksandrov
approved these changes
Mar 15, 2023
joamaki
approved these changes
Mar 15, 2023
|
/test |
tommyp1ckles
approved these changes
Mar 15, 2023
In preparation of moving the datapath module into datapath/cells.go, we need to break import cycles by moving the interface definitions into their own package. Reuse the existing datapath/types package for this, and adjust code and tests everywhere accordingly. Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
Now that there are no more circular imports, we can move the datapath cell and associated initialization code to pkg/datapath. The sysctl stuff should most definitely not live toplevel here, but one step at a time. Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
bimmlerd
force-pushed
the
pr/bimmlerd/move-datapath-types
branch
from
96f0af1
to
88fa6d4
Compare
|
Rebased on master to get the cluster-mesh tests working, was missing the kind setup introduced in #23496. |
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
|
Strangely, the build-push-prs image job timed out even though there are just two commits in the PR. 😕 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation of moving the datapath module into datapath/cells.go, we need to break import cycles by moving the datapath interface definitions into their own package. Use the existing
datapath/typespackage for this, and adjust code and tests everywhere accordingly. Then move the datapath module and associated initialization code to pkg/datapath.The sysctl stuff should most definitely not live top level in
pkg/datapath, but given this touches a million things, I'd like to keep the functional diff minimal and just move code around.