Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break import cycles and move the datapath cell to datapath/cell.go #24337

Merged
merged 2 commits into from
Mar 16, 2023
Merged

Break import cycles and move the datapath cell to datapath/cell.go #24337

merged 2 commits into from
Mar 16, 2023

Commits on Mar 16, 2023

  1. datapath: move interface definitions to /types 

    In preparation of moving the datapath module into datapath/cells.go, we
need to break import cycles by moving the interface definitions into
their own package. Reuse the existing datapath/types package for this,
and adjust code and tests everywhere accordingly.

Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
    @bimmlerd
    bimmlerd committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    d32eaaa View commit details
    Browse the repository at this point in the history

  2. daemon: move datapath cell to pkg/datapath 

    Now that there are no more circular imports, we can move the datapath
cell and associated initialization code to pkg/datapath.

The sysctl stuff should most definitely not live toplevel here, but one
step at a time.

Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
    @bimmlerd
    bimmlerd committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    88fa6d4 View commit details
    Browse the repository at this point in the history