Revert "docs: fix Rule spec document typos" #24418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit 0e403b85c8a7f2a383212e8e8a9ffd55255be176 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
added
dont-merge/needs-sign-off
This reverts commit a97f1f4. Signed-off-by: Aditi Ghag <aditi@cilium.io>
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
aditighag
added
dont-merge/needs-sign-off
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
aditighag
removed
the
dont-merge/needs-sign-off
nathanjsweet
approved these changes
Mar 16, 2023
tklauser
added
the
ready-to-merge
|
Sorry to bother you. I recreated this PR. The CI (generate k8s api) worked this time and it was successful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a97f1f4.
The linters should have failed on the PR, but for some reason they didn't.
/cc @nrnrk Please run
make generate-k8s-apilocally before submitting the changes.See the failure on other runs - https://github.com/cilium/cilium/actions/runs/4440944264/jobs/7795725126?pr=23831