.github: Rename failure step in actions #24437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the way that GitHub renders failing jobs here is that the "Install cilium chart" step will fail, then the "Capture cilium-sysdump" step will be collapsed. Recently we added `cilium status` output into this step, but unless developers know to click on this step and expand the output to investigate the cluster status, it's not obvious whether the failure is a random CI issue or whether there is some cause related to their changes. Renaming the failure step here will hopefully give a slightly better signal to developers when a failure is caused by their changes, and that they should take a closer look at the sysdump to confirm the failure condition. Signed-off-by: Joe Stringer <joe@cilium.io>
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
nbusseneau
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the way that GitHub renders failing jobs here is that the
"Install cilium chart" step will fail, then the "Capture cilium-sysdump"
step will be collapsed. Recently we added
cilium statusoutput intothis step, but unless developers know to click on this step and expand
the output to investigate the cluster status, it's not obvious whether
the failure is a random CI issue or whether there is some cause related
to their changes.
Renaming the failure step here will hopefully give a slightly better
signal to developers when a failure is caused by their changes, and that
they should take a closer look at the sysdump to confirm the failure
condition.