Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken links #24488

Merged
merged 1 commit into from Mar 22, 2023
Merged

Fix broken links #24488

merged 1 commit into from Mar 22, 2023

Conversation

PriyaSharma9
Copy link
Contributor

@PriyaSharma9 PriyaSharma9 commented Mar 21, 2023 •
edited by qmonnet

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Fixed broken links to Layer 7 policy.

README.rst: Fix broken link to L7 policies

@PriyaSharma9 PriyaSharma9 requested a review from a team as a code owner March 21, 2023 08:22
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 21, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Mar 21, 2023
@maintainer-s-little-helper
Copy link

Commit 1aba8b2ed5e870d58f9a6e179d29ca215ebc1f52 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Mar 21, 2023
@maintainer-s-little-helper
Copy link

Commits 1aba8b2ed5e870d58f9a6e179d29ca215ebc1f52, 3b27a39417cf46de2b7ffeb84bae94a182c807f2 do not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

qmonnet
qmonnet reviewed Mar 21, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Can you please rebase your branch to get rid of the two merge commits? Something like git fetch origin master; git rebase origin/master master should work, I think.

@qmonnet qmonnet added the release-note/misc This PR makes changes that have no direct user impact. label Mar 21, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 21, 2023
@maintainer-s-little-helper
Copy link

Commits 1aba8b2ed5e870d58f9a6e179d29ca215ebc1f52, 3b27a39417cf46de2b7ffeb84bae94a182c807f2, 1958edf52f96da786d947553cfd666aea7067094 do not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@PriyaSharma9
Fix broken links
30b913c 
Signed-off-by: Priya Sharma <Priya.Sharma6693@gmail.com>
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Mar 21, 2023
@PriyaSharma9
Copy link
Contributor Author

@qmonnet Please let me know if the commit I did just now is ok?

qmonnet
qmonnet approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@qmonnet
Copy link
Member

qmonnet commented Mar 21, 2023

README.rst change only, no full CI suite required. This is good to merge.

@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 21, 2023
@borkmann borkmann merged commit c8b7e0d into cilium:master Mar 22, 2023
40 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PriyaSharma9 @qmonnet @borkmann