workflows/externalworkload: Avoid using --config when unnecessary
#24567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should pass the config directly via --helm-set instead of overriding the ConfigMap after it's installed. Signed-off-by: Paul Chaignon <paul@cilium.io>
The previous commit changed the installation command to use '--helm-set=tunnel=vxlan' instead of '--config tunnel=vxlan'. This however ends up breaking the installation because the Helm flag conflict with the datapath mode detected by the CLI and the datapath mode takes precedence. Since this is running in GKE, the CLI detects gke as the datapath mode and tunneling mode is disabled. It used to work because '--config tunnel=vxlan' would override the value in the ConfigMap after the installation is done. Instead of fighting against the CLI, let's just tell it to use tunneling mode, with --datapath-mode=tunnel. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
pr/pchaigno/workflow-use-helm-set
branch
from
520b1d6
to
b67cbd3
Compare
pchaigno
changed the title
--helm-set--config when unnecessary
pchaigno
force-pushed
the
pr/pchaigno/workflow-use-helm-set
branch
from
b67cbd3
to
793ebd5
Compare
aanm
approved these changes
Mar 27, 2023
tklauser
approved these changes
Mar 27, 2023
pchaigno
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit makes use of
--helm-setinstead of--config. Second commit uses--datapath-mode=tunnelto enable tunneling mode.Passing test run: https://github.com/cilium/cilium/actions/runs/4520866855.