Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflows/externalworkload: Avoid using --config when unnecessary #24567

Merged
merged 2 commits into from
Mar 28, 2023
Merged

workflows/externalworkload: Avoid using --config when unnecessary #24567

merged 2 commits into from
Mar 28, 2023

Commits on Mar 25, 2023

  1. workflows/externalworkload: Use --helm-set instead of --config 

    We should pass the config directly via --helm-set instead of overriding
the ConfigMap after it's installed.

Signed-off-by: Paul Chaignon <paul@cilium.io>
    @pchaigno
    pchaigno committed Mar 25, 2023
    Configuration menu
    Copy the full SHA
    e434330 View commit details
    Browse the repository at this point in the history

  2. workflows/externalworkload: Set tunnel mode via --datapath-mode 

    The previous commit changed the installation command to use
'--helm-set=tunnel=vxlan' instead of '--config tunnel=vxlan'.

This however ends up breaking the installation because the Helm flag
conflict with the datapath mode detected by the CLI and the datapath
mode takes precedence. Since this is running in GKE, the CLI detects gke
as the datapath mode and tunneling mode is disabled.

It used to work because '--config tunnel=vxlan' would override the value
in the ConfigMap after the installation is done.

Instead of fighting against the CLI, let's just tell it to use tunneling
mode, with --datapath-mode=tunnel.

Signed-off-by: Paul Chaignon <paul@cilium.io>
    @pchaigno
    pchaigno committed Mar 25, 2023
    Configuration menu
    Copy the full SHA
    793ebd5 View commit details
    Browse the repository at this point in the history