Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CODEOWNERS update hint #24583

Merged
merged 1 commit into from Mar 30, 2023
Merged

Fix CODEOWNERS update hint #24583

merged 1 commit into from Mar 30, 2023

Conversation

ferozsalam
Copy link
Contributor

@ferozsalam ferozsalam commented Mar 27, 2023 •
edited by qmonnet

The suggested target doesn't exist

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!
docs: Fix Makefile target name in CODEOWNERS update hint

@ferozsalam
Fix CODEOWNERS update hint
068de27 
The suggested target doesn't exist

Signed-off-by: Feroz Salam <feroz@argh.in>
@ferozsalam ferozsalam added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Mar 27, 2023
@ferozsalam ferozsalam requested a review from a team as a code owner March 27, 2023 15:09
@ferozsalam ferozsalam requested a review from qmonnet March 27, 2023 15:09
qmonnet
qmonnet approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 30, 2023
@julianwiedmann julianwiedmann merged commit d855e6f into master Mar 30, 2023
35 checks passed
@julianwiedmann julianwiedmann deleted the pr/fix-codeowners-check branch March 30, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ferozsalam @qmonnet @julianwiedmann