daemon: ignore EEXIST on NodeEnsureLocalIPRule #24645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to Nik, some Kernel versions (namely 4.9 which is still
supported in v1.13) doesn't support the fib rule protocol attribute.
The call fails with the following error:
daemon creation failed: error while initializing daemon: failed to ensure local IP rules: could not replace IPv4 local rule: file exists"
See #24607 (comment)
In order to ease backporting, let's also apply this change on master
even though 4.9 is no longer supported (ref. #22116). The EEXIST case
should not occur on kernels which support the fib rule protocol
attribute.
Fixes: 291852a ("datapath/linux: make sure we have a local rule with proto kernel")
Suggested-by: Nikolay Aleksandrov <nikolay@isovalent.com>
Co-authored-by: Nikolay Aleksandrov <nikolay@isovalent.com>
Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
added
release-note/misc
NikAleksandrov
approved these changes
Mar 30, 2023
|
/test Job 'Cilium-PR-K8s-1.24-kernel-5.4' failed: Click to show.Test NameFailure OutputIf it is a flake and a GitHub issue doesn't already exist to track it, comment |
pippolo84
approved these changes
Mar 30, 2023
|
/test-1.24-5.4 hit #24253: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.24-kernel-5.4/1492/ |
maintainer-s-little-helper
bot
added
the
ready-to-merge
tklauser
added
backport-pending/1.13
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.13
in 1.13.2
tklauser
added
needs-backport/1.13
maintainer-s-little-helper
bot
moved this from Backport pending to v1.13
to Needs backport from master
in 1.13.2
maintainer-s-little-helper
bot
moved this from Backport pending to v1.13
to Needs backport from master
in 1.13.2
jibi
removed
affects/v1.11
|
Dropping the backporting labels as the PR it fixes has been reverted #24288 |
jibi
added
affects/v1.11
For v1.13 we now require a kernel >= 4.19, thus dropping the backport label. |
julianwiedmann
removed
the
needs-backport/1.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Nik, some Kernel versions (namely 4.9 which is still supported in v1.13) doesn't support the fib rule protocol attribute. The call fails with the following error:
See #24607 (comment)
In order to ease backporting, let's also apply this change on master even though 4.9 is no longer supported (ref. #22116). The EEXIST case should not occur on kernels which support the fib rule protocol attribute.
Fixes: 291852a ("datapath/linux: make sure we have a local rule with proto kernel")