-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
daemon: ignore EEXIST on NodeEnsureLocalIPRule #24645
Conversation
According to Nik, some Kernel versions (namely 4.9 which is still supported in v1.13) doesn't support the fib rule protocol attribute. The call fails with the following error: daemon creation failed: error while initializing daemon: failed to ensure local IP rules: could not replace IPv4 local rule: file exists" See #24607 (comment) In order to ease backporting, let's also apply this change on master even though 4.9 is no longer supported (ref. #22116). The EEXIST case should not occur on kernels which support the fib rule protocol attribute. Fixes: 291852a ("datapath/linux: make sure we have a local rule with proto kernel") Suggested-by: Nikolay Aleksandrov <nikolay@isovalent.com> Co-authored-by: Nikolay Aleksandrov <nikolay@isovalent.com> Signed-off-by: Tobias Klauser <tobias@cilium.io>
/test Job 'Cilium-PR-K8s-1.24-kernel-5.4' failed: Click to show.Test Name
Failure Output
If it is a flake and a GitHub issue doesn't already exist to track it, comment |
/test-1.24-5.4 hit #24253: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.24-kernel-5.4/1492/ |
Dropping the backporting labels as the PR it fixes has been reverted #24288 |
For v1.13 we now require a kernel >= 4.19, thus dropping the backport label. |
According to Nik, some Kernel versions (namely 4.9 which is still supported in v1.13) doesn't support the fib rule protocol attribute. The call fails with the following error:
See #24607 (comment)
In order to ease backporting, let's also apply this change on master even though 4.9 is no longer supported (ref. #22116). The EEXIST case should not occur on kernels which support the fib rule protocol attribute.
Fixes: 291852a ("datapath/linux: make sure we have a local rule with proto kernel")