Revert https://github.com/cilium/cilium/pull/24288 #24676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
added
the
release-note/misc
aanm
requested review from
sayboras,
gentoo-root,
ldelossa,
YutaroHayakawa and
squeed
aanm
force-pushed
the
pr/revert-breaking-update
branch
from
c6afdcd
to
6426341
Compare
|
/test |
…nel" This reverts commit 291852a. Signed-off-by: André Martins <andre@cilium.io>
This reverts commit 9e3abdf. Signed-off-by: André Martins <andre@cilium.io>
This reverts commit 660fd79. Signed-off-by: André Martins <andre@cilium.io>
This reverts commit f29b435. Signed-off-by: André Martins <andre@cilium.io>
…ules" This reverts commit 1d319cf. Signed-off-by: André Martins <andre@cilium.io>
This reverts commit c483441. Signed-off-by: André Martins <andre@cilium.io>
This reverts commit dddfb36. Signed-off-by: André Martins <andre@cilium.io>
This reverts commit cd318f8. Signed-off-by: André Martins <andre@cilium.io>
This reverts commit d0cca9d. Signed-off-by: André Martins <andre@cilium.io>
This reverts commit 0557242. Signed-off-by: André Martins <andre@cilium.io>
This reverts commit e370f6e. Signed-off-by: André Martins <andre@cilium.io>
This reverts commit d28e1aa. Signed-off-by: André Martins <andre@cilium.io>
This reverts commit c5403f1. Signed-off-by: André Martins <andre@cilium.io>
…and routes" This reverts commit 011bb96. Signed-off-by: André Martins <andre@cilium.io>
aanm
force-pushed
the
pr/revert-breaking-update
branch
from
6426341
to
239e332
Compare
|
/test Job 'Cilium-PR-K8s-1.25-kernel-4.19' failed: Click to show.Test NameFailure OutputIf it is a flake and a GitHub issue doesn't already exist to track it, comment |
sayboras
approved these changes
Mar 31, 2023
pchaigno
requested changes
Mar 31, 2023
There was a problem hiding this comment.
You will also need to revert https://github.com/cilium/cilium/pull/24577/commits.
…mat" This reverts commit cbf09e7. Signed-off-by: André Martins <andre@cilium.io>
|
/test Job 'Cilium-PR-K8s-1.16-kernel-4.19' failed: Click to show.Test NameFailure OutputIf it is a flake and a GitHub issue doesn't already exist to track it, comment |
pchaigno
approved these changes
Mar 31, 2023
|
/test-1.16-4.19 |
YutaroHayakawa
approved these changes
Apr 1, 2023
|
I hate to spoil the party, but still seeing this fail with the revert applied: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #24288 and #24577 introduced a regression on the upgrade from 1.13 to latest. Thus, we will revert all commits from this PR so that we can have the CI in a healthy state.
cc @NikAleksandrov
Fixes #24573
Verified locally that upgrade test doesn't fail after this.