k8s: api: clean up CRD versioning #24671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
julianwiedmann
force-pushed
the
1.14-crd-version
branch
2 times, most recently
from
035799c
to
f7f95f6
Compare
julianwiedmann
added
sig/k8s
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
/test |
aanm
requested changes
Mar 31, 2023
joestringer
approved these changes
Mar 31, 2023
julianwiedmann
force-pushed
the
1.14-crd-version
branch
from
f7f95f6
to
74fda7f
Compare
|
/test Job 'Cilium-PR-K8s-1.24-kernel-5.4' failed: Click to show.Test NameFailure OutputIf it is a flake and a GitHub issue doesn't already exist to track it, comment Job 'Cilium-PR-K8s-1.26-kernel-net-next' failed: Click to show.Test NameFailure OutputIf it is a flake and a GitHub issue doesn't already exist to track it, comment |
aanm
approved these changes
Apr 3, 2023
The `v2` and `v2alpha1` variants of CustomResourceDefinitionGroup are just indirections of the same constant. The operator's CRD code needs to handle both v2 and v2alpha1 CRDs. Make it clear that the used CustomResourceDefinitionGroup isn't tied to v2. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
Both v2 and v2alpha1 use the same label string for the CRD Schema Version. Add a shared constant to clarify that the relevant operator code isn't actually tied to v2. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
We've been maintaining distinct CRD Schema versions for v2 and v2alpha1. But the operator actually only cared about the v2 version. So make it clear that this is a shared version across both v2 and v2alpha1. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
|
The update test failed in two runs (https://jenkins.cilium.io/job/Cilium-PR-K8s-1.16-kernel-4.19/749/, https://jenkins.cilium.io/job/Cilium-PR-K8s-1.26-kernel-net-next/1602/). Maybe because the branch didn't have #24676, or maybe because it's not actually resolved yet (#24687). Let's rebase and find out. |
julianwiedmann
force-pushed
the
1.14-crd-version
branch
from
74fda7f
to
b3554ee
Compare
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up some confusion in the
v2/v2alpha1versioning for CRDs. Turns out theCustomResourceDefinitionSchemaVersionforv2alpha1isn't actually used anymore.