bpf: nodeport: trivial cleanups #24732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianwiedmann
added
sig/datapath
aspsk
reviewed
Apr 5, 2023
aspsk
approved these changes
Apr 5, 2023
|
/test |
Align tail_nodeport_nat_egress_ipv6() with the IPv4 variant, by using `oif` to transport the ifindex for redirect to the encap interface. No functional change. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
The comment regarding a `dir` branch is from back when we had a shared tail-call for Ingress & Egress NAT handling. Now that this has been split in two tail-calls, the comment doesn't make any sense. Clean it up. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann
force-pushed
the
1.14-nodeport-ifindex
branch
from
795af0e
to
0ee2d5b
Compare
|
/test |
|
The |
julianwiedmann
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two tiny cleanups I've been carrying for a while in a feature branch. Maybe they are helpful to others as well.