Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in doc: network/concepts/ipam/crd.rst #24908

Merged
merged 1 commit into from Apr 17, 2023
Merged

Fix typo in doc: network/concepts/ipam/crd.rst #24908

merged 1 commit into from Apr 17, 2023

Conversation

takp
Copy link
Contributor

@takp takp commented Apr 14, 2023

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Fixes typo in Documentation/network/concepts/ipam/crd.rst

@takp
Fix typo in network/concepts/ipam/crd.rst
559a4af 
Signed-off-by: Takayoshi Nishida <takayoshi.nishida@gmail.com>
@takp takp requested review from a team as code owners April 14, 2023 23:45
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 14, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Apr 14, 2023
@pchaigno pchaigno added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Apr 15, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Apr 15, 2023
@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 15, 2023
gandro
gandro approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pchaigno pchaigno merged commit cf3cc10 into cilium:master Apr 17, 2023
36 checks passed
@takp takp deleted the fix-typo-in-doc-crd.rst branch April 17, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@pchaigno pchaigno pchaigno approved these changes

@zacharysarah zacharysarah Awaiting requested review from zacharysarah zacharysarah was automatically assigned from cilium/docs-structure

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@takp @gandro @pchaigno