Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: ConformanceDatapath: Incorrect status if jobs are skipped #24915

Closed
pchaigno opened this issue Apr 16, 2023 · 2 comments · Fixed by #24922
Closed

CI: ConformanceDatapath: Incorrect status if jobs are skipped #24915

pchaigno opened this issue Apr 16, 2023 · 2 comments · Fixed by #24922
Labels
area/CI Continuous Integration testing issue or flake good-first-issue Good starting point for new developers, which requires minimal understanding of Cilium. kind/bug/CI This is a bug in the testing code.

Comments

@pchaigno
Copy link
Member

The ConformanceDatapath workflow doesn't properly set its status on GitHub if the test is skipped. In such cases, the workflow remains indefinitely in Pending state.

Example: https://github.com/cilium/cilium/actions/runs/4699458917
image
@pchaigno pchaigno added kind/bug/CI This is a bug in the testing code. area/CI Continuous Integration testing issue or flake good-first-issue Good starting point for new developers, which requires minimal understanding of Cilium. labels Apr 16, 2023
@pchaigno pchaigno mentioned this issue Apr 16, 2023
Merged
@gandro
Copy link
Member

gandro commented Apr 17, 2023 •
edited

Interesting. This likely also applies to other workflows (ci-verifier, ci-clustermesh) that use the same pattern as well. I guess we need to fix Set commit status to set the test as succeeded instead of as pending if code changes have skipped the workflow.

@gandro gandro mentioned this issue Apr 17, 2023
Merged
@gandro
Copy link
Member

gandro commented Apr 17, 2023

Turns out ci-verifier and ci-clustermesh do already have a job which checks this. I will copy that one over to ci-datapath.

gandro added a commit that referenced this issue Apr 17, 2023
@gandro
ci-datapath: Fix incorrect status if jobs are skipped
0ac9512 
The ConformanceDatapath workflow did not properly set its status on
GitHub if the test is skipped. This commit fixes that issue by copying
over the `skip-test-run` job from ci-verifier and ci-clustermesh, which
was missed when we introduced the separate status reporting jobs.

Fixes: #24915

Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
pchaigno pushed a commit that referenced this issue Apr 17, 2023
@gandro @pchaigno
ci-datapath: Fix incorrect status if jobs are skipped
ec4db88 
The ConformanceDatapath workflow did not properly set its status on
GitHub if the test is skipped. This commit fixes that issue by copying
over the `skip-test-run` job from ci-verifier and ci-clustermesh, which
was missed when we introduced the separate status reporting jobs.

Fixes: #24915

Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake good-first-issue Good starting point for new developers, which requires minimal understanding of Cilium. kind/bug/CI This is a bug in the testing code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: Mark skipped matrix workflows as successful cilium/cilium
2 participants
@gandro @pchaigno