ci: Mark skipped matrix workflows as successful #24922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gandro
force-pushed
the
pr/gandro/fix-skipped-test-reporting
branch
from
8bb72f6
to
4b1549f
Compare
The ConformanceDatapath workflow did not properly set its status on GitHub if the test is skipped. This commit fixes that issue by copying over the `skip-test-run` job from ci-verifier and ci-clustermesh, which was missed when we introduced the separate status reporting jobs. Fixes: #24915 Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
force-pushed
the
pr/gandro/fix-skipped-test-reporting
branch
from
4b1549f
to
0ac9512
Compare
pchaigno
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ConformanceDatapath workflow did not properly set its status on GitHub if the test is skipped. This commit fixes that issue by copying over the
skip-test-runjob from ci-verifier and ci-clustermesh, which was missed when we introduced the separate status reporting jobs.Fixes: #24915
Note that this cannot easily be tested with a
pull_requesttarget since it relies on the issue comment body, which will only be available once this PR has been merged to master.