Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: add the kind-based clustermesh conformance test for stable branches #25029

Merged
merged 2 commits into from Apr 24, 2023

Conversation

giorio94
Copy link
Member

This PR adds a copy of the new clustermesh conformance test initially introduced in #23496 for each of the currently active stable branches (i.e., v1.11, v1.12 and v1.13). Trigger phrases and Kubernetes
versions are updated accordingly.

Fixes: #issue-number

workflows: add the kind-based clustermesh conformance test for stable branches

@giorio94 giorio94 added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Apr 21, 2023
@maintainer-s-little-helper

This comment was marked as resolved.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Apr 21, 2023
@maintainer-s-little-helper

This comment was marked as resolved.

This commit extends the `kind-config.yaml.tmpl` template to allow
specifying the kubernetes version of the nodes, and updates the
clustermesh conformance test to set it accordingly. This is required
to allow configuring different kubernetes versions for the tests
targeting stable branches.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94 giorio94 force-pushed the pr/giorio94/conformance-clustermesh-stable-branches branch from c9c4f2d to 9c06b25 Compare April 21, 2023 09:08
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Apr 21, 2023
@giorio94 giorio94 force-pushed the pr/giorio94/conformance-clustermesh-stable-branches branch from 9c06b25 to 1b29e0c Compare April 21, 2023 10:07
This commit adds a copy of the new clustermesh conformance test
initially introduced in #23496 for each of the currently active stable
branches (i.e., v1.11, v1.12 and v1.13). Trigger phrases and Kubernetes
versions are updated accordingly.

In case of v1.11, the direct-routing IPv6 and IPv4+IPv6 tests have been
disabled since that configuration is currently affected a bug causing
incorrect masquerading of traffic directed to remote pods.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94 giorio94 force-pushed the pr/giorio94/conformance-clustermesh-stable-branches branch 2 times, most recently from 9d4d461 to 621c276 Compare April 21, 2023 15:14
@giorio94
Copy link
Member Author

Link to successful runs:

I'm dropping the test commits and marking as ready for review.

@giorio94 giorio94 marked this pull request as ready for review April 21, 2023 15:14
@giorio94 giorio94 requested review from a team as code owners April 21, 2023 15:14
Copy link
Contributor

@viktor-kurchenko viktor-kurchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@bimmlerd bimmlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.

@pchaigno pchaigno merged commit 89d1700 into main Apr 24, 2023
43 checks passed
@pchaigno pchaigno deleted the pr/giorio94/conformance-clustermesh-stable-branches branch April 24, 2023 09:20
dlapcevic pushed a commit to dlapcevic/cilium that referenced this pull request Jul 3, 2023
The new kind-based clustermesh workflows ported to all stable branches
in cilium#25029 have now run for a while in parallel with the old ones,
and they seems comparably stable while covering more scenarios. Hence,
let's drop the old ones, as we already did in cilium#24996 for main.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants