New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflows: add the kind-based clustermesh conformance test for stable branches #25029
Merged
pchaigno
merged 2 commits into
main
from
pr/giorio94/conformance-clustermesh-stable-branches
Apr 24, 2023
Merged
workflows: add the kind-based clustermesh conformance test for stable branches #25029
pchaigno
merged 2 commits into
main
from
pr/giorio94/conformance-clustermesh-stable-branches
Apr 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giorio94
added
area/CI
Continuous Integration testing issue or flake
release-note/ci
This PR makes changes to the CI.
labels
Apr 21, 2023
This comment was marked as resolved.
This comment was marked as resolved.
maintainer-s-little-helper
bot
added
the
dont-merge/needs-sign-off
The author needs to add signoff to their commits before merge.
label
Apr 21, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This commit extends the `kind-config.yaml.tmpl` template to allow specifying the kubernetes version of the nodes, and updates the clustermesh conformance test to set it accordingly. This is required to allow configuring different kubernetes versions for the tests targeting stable branches. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
force-pushed
the
pr/giorio94/conformance-clustermesh-stable-branches
branch
from
April 21, 2023 09:08
c9c4f2d
to
9c06b25
Compare
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
The author needs to add signoff to their commits before merge.
label
Apr 21, 2023
giorio94
force-pushed
the
pr/giorio94/conformance-clustermesh-stable-branches
branch
from
April 21, 2023 10:07
9c06b25
to
1b29e0c
Compare
This commit adds a copy of the new clustermesh conformance test initially introduced in #23496 for each of the currently active stable branches (i.e., v1.11, v1.12 and v1.13). Trigger phrases and Kubernetes versions are updated accordingly. In case of v1.11, the direct-routing IPv6 and IPv4+IPv6 tests have been disabled since that configuration is currently affected a bug causing incorrect masquerading of traffic directed to remote pods. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
force-pushed
the
pr/giorio94/conformance-clustermesh-stable-branches
branch
2 times, most recently
from
April 21, 2023 15:14
9d4d461
to
621c276
Compare
Link to successful runs:
I'm dropping the test commits and marking as ready for review. |
pchaigno
approved these changes
Apr 21, 2023
viktor-kurchenko
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
bimmlerd
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice.
pchaigno
deleted the
pr/giorio94/conformance-clustermesh-stable-branches
branch
April 24, 2023 09:20
1 task
dlapcevic
pushed a commit
to dlapcevic/cilium
that referenced
this pull request
Jul 3, 2023
The new kind-based clustermesh workflows ported to all stable branches in cilium#25029 have now run for a while in parallel with the old ones, and they seems comparably stable while covering more scenarios. Hence, let's drop the old ones, as we already did in cilium#24996 for main. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/CI
Continuous Integration testing issue or flake
release-note/ci
This PR makes changes to the CI.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a copy of the new clustermesh conformance test initially introduced in #23496 for each of the currently active stable branches (i.e., v1.11, v1.12 and v1.13). Trigger phrases and Kubernetes
versions are updated accordingly.
Fixes: #issue-number