Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.13] datapath: Remove 2005 route table for IPv4 #25086

Merged
merged 2 commits into from Apr 25, 2023
Merged

[v1.13] datapath: Remove 2005 route table for IPv4 #25086

merged 2 commits into from Apr 25, 2023

Conversation

julianwiedmann
Copy link
Member

@julianwiedmann julianwiedmann commented Apr 24, 2023 •
edited

Backporting

Once this PR is merged, you can update the PR labels via:

for pr in 24807; do contrib/backporting/set-labels.py $pr done 1.13; done

or with

make add-labels BRANCH=v1.13 ISSUES=24807

@jschwinger233 @julianwiedmann
datapath: remove 2005 route table for ipv4 only
70d07a7 
[ upstream commit c1a0dba ]

This reverts commit 3ed62d5 partially and only removes ipv4 2005 route
table.

Fixes: cilium#21954

Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@jschwinger233 @julianwiedmann
test: add e2e test for reaching nodeport from outside with L7 policy
08618e8 
[ upstream commit 17df079 ]

This commit adds e2e test to cover issue cilium#21954.

Test cases for IPv6 are deleted and PR cilium#24882 will take care of them.

Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann added kind/backports This PR provides functionality previously merged into master. backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. labels Apr 24, 2023
@julianwiedmann julianwiedmann requested a review from a team as a code owner April 24, 2023 13:18
@julianwiedmann
Copy link
Member Author

julianwiedmann commented Apr 24, 2023 •
edited by maintainer-s-little-helper bot

/test-backport-1.13

Job 'Cilium-PR-K8s-1.25-kernel-4.19' failed:

Click to show.

Test Name

K8sDatapathServicesTest Checks E/W loadbalancing (ClusterIP, NodePort from inside cluster, etc) with L7 policy Tests NodePort with L7 Policy

Failure Output

FAIL: Request from k8s1 to service http://[fd04::11]:30557 failed

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.25-kernel-4.19/1850/

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.25-kernel-4.19 so I can create one.

@jschwinger233
Copy link
Member

Thank you!

@michi-covalent
Copy link
Contributor

ci-multicluster-1.13: looks like it's hitting this error consistently 👀

line 1: ./.github/kind-config.yaml.tmpl: No such file or directory

i guess https://github.com/julianwiedmann/cilium/tree/v1.13-ipv4-2005/ needs to be synced with upstream v1.13 branch?

@michi-covalent
Copy link
Contributor

i guess https://github.com/julianwiedmann/cilium/tree/v1.13-ipv4-2005/ needs to be synced with upstream v1.13 branch?

i take it back. i think this is an issue with the workflow file itself. it recently got added in #25029

@michi-covalent
Copy link
Contributor

ci-aks-1.13: failed to create a cluster. retrying...

ERROR: (ResourceGroupBeingDeleted) The resource group 'cilium-cilium-4786801895' is in deprovisioning state and cannot perform this operation.
Code: ResourceGroupBeingDeleted
Message: The resource group 'cilium-cilium-4786801895' is in deprovisioning state and cannot perform this operation.

@michi-covalent
Copy link
Contributor

michi-covalent commented Apr 24, 2023 •
edited by maintainer-s-little-helper bot

/mlh new-flake Cilium-PR-K8s-1.25-kernel-4.19

👍 created #25096

@michi-covalent
Copy link
Contributor

/test-1.25-4.19

This was referenced Apr 24, 2023
Merged
Merged
@michi-covalent
Copy link
Contributor

ci-aks-1.13: filed #25097

@michi-covalent
Copy link
Contributor

/ci-aks-1.13

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 25, 2023
@michi-covalent michi-covalent merged commit 8230cdb into cilium:v1.13 Apr 25, 2023
61 of 62 checks passed
@thorn3r thorn3r mentioned this pull request May 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschwinger233 jschwinger233 jschwinger233 approved these changes

@michi-covalent michi-covalent michi-covalent approved these changes

Assignees
No one assigned
Labels
backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@julianwiedmann @jschwinger233 @michi-covalent