Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source: Reorder sources based on strength #25175

Merged
merged 1 commit into from Apr 28, 2023
Merged

source: Reorder sources based on strength #25175

merged 1 commit into from Apr 28, 2023

Conversation

christarazi
Copy link
Member

This commit is purely cosmetic and only reorders the definition based
on the strength of the source, from top to bottom.

Signed-off-by: Chris Tarazi chris@isovalent.com

@christarazi
source: Reorder sources based on strength
f9fe5c6 
This commit is purely cosmetic and only reorders the definition based
on the strength of the source, from top to bottom.

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi christarazi added kind/cleanup This includes no functional changes. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies. release-note/misc This PR makes changes that have no direct user impact. labels Apr 27, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Apr 27, 2023
@christarazi christarazi marked this pull request as ready for review April 27, 2023 21:48
@christarazi christarazi requested a review from a team as a code owner April 27, 2023 21:48
@christarazi
Copy link
Member Author

Noticed that no proper CODEOWNER is assigned for pkg/source so submitted #25176 to fix that.

@christarazi
Copy link
Member Author

christarazi commented Apr 27, 2023 •
edited

/test

Edit:

michi-covalent
michi-covalent approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😇

@christarazi
Copy link
Member Author

christarazi commented Apr 28, 2023 •
edited

PR does not change any logic and is a simple code swap-around; hit known flakes and has approving reviews. Marking ready to merge.

@christarazi christarazi added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 28, 2023
@michi-covalent
Copy link
Contributor

i'm watching you chris 👀

@christarazi
Copy link
Member Author

/test-runtime

@ti-mo ti-mo merged commit e903eb6 into cilium:main Apr 28, 2023
57 checks passed
@christarazi christarazi deleted the pr/christarazi/reorder-source branch April 28, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michi-covalent michi-covalent michi-covalent approved these changes

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@christarazi @michi-covalent @ti-mo